jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Gaul <notificati...@github.com>
Subject Re: [jclouds/jclouds] [JCLOUDS-1390] Use FULL projection to get metadata as part of list blobs response (#1184)
Date Wed, 07 Mar 2018 18:29:38 GMT
gaul requested changes on this pull request.

This looks great!

> @@ -192,8 +192,7 @@ public void setContainerAccess(String container, ContainerAccess
access) {
    public PageSet<? extends StorageMetadata> list(String container, ListContainerOptions
options) {
       ListObjectOptions listOptions = listContainerOptionsToListObjectOptions.apply(options);
       ListPageWithPrefixes<GoogleCloudStorageObject> gcsList = api.getObjectApi().listObjects(container,
listOptions);
-      PageSet<? extends StorageMetadata> list = objectListToStorageMetadata.apply(gcsList);
-      return options.isDetailed() ? fetchBlobMetadataProvider.get().setContainerName(container).apply(list)
: list;

Can we now remove `FetchBlobMetadata`?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1184#pullrequestreview-102043881
Mime
View raw message