jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Trevor Flanagan <notificati...@github.com>
Subject Re: [jclouds/jclouds-labs] JCLOUDS-1406 - Add default location configuration to dimension data provider (#433)
Date Thu, 12 Apr 2018 11:16:37 GMT
trevorflanagan commented on this pull request.



> @@ -40,6 +43,17 @@
 @ConfiguresHttpApi
 public class DimensionDataCloudControlHttpApiModule extends HttpApiModule<DimensionDataCloudControlApi>
{
 
+   @Override
+   protected void installLocations() {
+      super.installLocations();
+      //      bind(RegionIdToZoneIdsSupplier.class).to(ZonesForRegion.class).in(Scopes.SINGLETON);
+      bind(RegionIdToURISupplier.class).to(RegionsToApiEndpoints.class).in(Scopes.SINGLETON);

@nacx I wanted to make sure with you that I have the correct locations setup. Right now it's
just the conversion of the region to the URL.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/433#pullrequestreview-111576755
Mime
View raw message