jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrea Turli <notificati...@github.com>
Subject Re: [jclouds/jclouds-labs] [JCLOUDS-1430] Aliyun ECS (#443)
Date Thu, 02 Aug 2018 08:08:07 GMT
andreaturli commented on this pull request.



> +   private final Supplier<Map<String, ? extends Hardware>> hardwares;
+   private final Supplier<Set<? extends Location>> locations;
+   private final Function<Instance.Status, NodeMetadata.Status> toPortableStatus;
+   private final GroupNamingConvention groupNamingConvention;
+   @Resource @Named(ComputeServiceConstants.COMPUTE_LOGGER) protected Logger logger = Logger.NULL;
+
+   @Inject
+   public InstanceToNodeMetadata(InstanceTypeToHardware instanceTypeToHardware,
+                                 Supplier<Map<String, ? extends Image>> images,
+                                 Supplier<Map<String, ? extends Hardware>> hardwares,
+                                 @Memoized Supplier<Set<? extends Location>>
locations,
+                                 Function<Instance.Status, NodeMetadata.Status> toPortableStatus,
+                                 GroupNamingConvention.Factory groupNamingConvention) {
+      this.instanceTypeToHardware = instanceTypeToHardware;
+      this.images = checkNotNull(images, "images cannot be null");
+      this.hardwares = checkNotNull(hardwares, "hardwares cannot be null");

ok

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/443#discussion_r207135462
Mime
View raw message