jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds/jclouds-labs] [JCLOUDS-1430] Aliyun ECS (#443)
Date Mon, 06 Aug 2018 12:09:49 GMT
nacx commented on this pull request.



> @@ -54,6 +46,7 @@ protected Properties setupProperties() {
       Properties properties = super.setupProperties();
       vpcId = setIfTestSystemPropertyPresent(properties,  provider + ".vpcId");
       vSwitchId = setIfTestSystemPropertyPresent(properties,  provider + ".vSwitchId");
+      group = "jclouds"; // otherwise jclouds will use provider name as group but `aliyun`
is a forbidden prefix for tags

Sounds good. Preconfigure that and remove this from here.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/443#discussion_r207868271
Mime
View raw message