jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrea Turli <notificati...@github.com>
Subject Re: [jclouds/jclouds-labs] [JCLOUDS-1430] Aliyun ECS (#443)
Date Wed, 08 Aug 2018 20:14:50 GMT
andreaturli commented on this pull request.

>           } catch (Exception ex) {
             logger.warn(ex, "Error cleaning up resources for node %s", deadNode);
+         List<SecurityGroup> securityGroups = cleanupResources.findOrphanedSecurityGroups(regionAndId.regionId(),
+         for (SecurityGroup securityGroup : securityGroups) {
+            logger.debug(">> destroying security group %s ...", securityGroup.id());
+            if (cleanupResources.cleanupSecurityGroupIfOrphaned(regionAndId.regionId(), securityGroup.id()))
+               logger.debug(">> security group: (%s) has been deleted.", securityGroup.id());
+            } else {
+               logger.warn(">> security group: (%s) has not been deleted.", securityGroup.id());
+            }
+         }
+         // FIXME not sure it is correct to always delete vSwitch and VPC

thinking about it more, regardless of the tags, I think the question is whether is right to
destroy a VPC every time jclouds deletes a group of nodes or not. I honestly don't know the
answer as I can see value in both cases, so maybe an extra property configurable by the user?

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
View raw message