jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Phillips <notificati...@github.com>
Subject Re: [jclouds/jclouds] Filesystem: Fix the MPU ETags to match S3. (#1252)
Date Thu, 25 Oct 2018 22:56:42 GMT
demobox commented on this pull request.



> +         MultipartPart part1 = blobStore.uploadMultipartPart(mpu, 1, payload);
+         MultipartPart part2 = blobStore.uploadMultipartPart(mpu, 2, payload);
+
+         List<MultipartPart> parts = blobStore.listMultipartUpload(mpu);
+         assertThat(parts).hasSize(2);
+         assertThat(parts.get(0).partNumber()).isEqualTo(part1.partNumber());
+         assertThat(parts.get(0).partSize()).isEqualTo(part1.partSize());
+         assertThat(parts.get(0).partETag()).isEqualTo(part1.partETag());
+         assertThat(parts.get(1).partNumber()).isEqualTo(part2.partNumber());
+         assertThat(parts.get(1).partSize()).isEqualTo(part2.partSize());
+         assertThat(parts.get(1).partETag()).isEqualTo(part2.partETag());
+
+         blobStore.completeMultipartUpload(mpu, ImmutableList.of(part1, part2));
+
+         BlobMetadata newBlobMetadata = blobStore.blobMetadata(container, name);
+         assertThat(newBlobMetadata.getETag()).isEqualTo(expectedETag);

[minor] Is there anything other than this final assertion (regarding the expected ETag) that
we're trying to verify in this test?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1252#pullrequestreview-168619146
Mime
View raw message