jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ashkan Paya <notificati...@github.com>
Subject Re: [jclouds/jclouds] Fix for FileSystem blob store clearContainer with options (#1258)
Date Thu, 03 Jan 2019 23:49:47 GMT
Unsubscribe please.

From: reptillicus <notifications@github.com>
Reply-To: jclouds/jclouds <reply@reply.github.com>
Date: Thursday, January 3, 2019 at 3:48 PM
To: jclouds/jclouds <jclouds@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: Re: [jclouds/jclouds] Fix for FileSystem blob store clearContainer with options (#1258)


[EXTERNAL EMAIL]

@reptillicus commented on this pull request.

________________________________

In apis/filesystem/src/main/java/org/jclouds/filesystem/strategy/internal/FilesystemStorageStrategyImpl.java<https://github.com/jclouds/jclouds/pull/1258#discussion_r245169336>:

> @@ -254,15 +255,49 @@ public void clearContainer(final String container) {

    public void clearContainer(String container, ListContainerOptions options) {

       filesystemContainerNameValidator.validate(container);

       // TODO: these require calling removeDirectoriesTreeOfBlobKey

-      checkArgument(options.getDir() == null && options.getPrefix() == null, "cannot
specify directory or prefix");

+//      checkArgument(options.getDir() == null && options.getPrefix() == null, "cannot
specify directory or prefix");

+      String optsPrefix;

+      // Pick whichever one is not null? Not sure what to do until inDirectory is deprecated.

+      optsPrefix = options.getDir() == null ? options.getPrefix() : options.getDir();

+      // If both are null, just use an empty string

+      optsPrefix = optsPrefix == null ? "" : optsPrefix;

changed

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<https://github.com/jclouds/jclouds/pull/1258#discussion_r245169336>,
or mute the thread<https://github.com/notifications/unsubscribe-auth/AD--O2oLmummCoYBaov05oWkX1grPEW9ks5u_pa8gaJpZM4YqOLU>.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1258#issuecomment-451314978
Mime
View raw message