jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Gaul <notificati...@github.com>
Subject Re: [jclouds/jclouds] JCLOUDS-1465: Added test for large multipart uploads (#1266)
Date Fri, 04 Jan 2019 18:12:32 GMT
gaul requested changes on this pull request.



> @@ -74,4 +74,9 @@ public void testPutBlobTierArchiveMultipart() throws Exception {
          throw new SkipException("S3 does not allow setting Glacier storage class on putBlob",
hre);
       }
    }
+
+   @Override
+   public void testPutHugeObject() throws Exception {

Does this method have a purpose?  Subclasses will inherit this functionality without overriding
it.

> @@ -685,6 +686,32 @@ public void testPutMultipartInputStream() throws Exception {
       testPut(payload, null, new ByteSourcePayload(byteSource), length, new PutOptions().multipart(true));
    }
 
+   @Test(groups = { "integration", "live" })
+   public void testPutHugeObject() throws Exception {
+      //Create a 25GB file, 
+      long length = 25L * 1024L  * 1024L * 1024L;
+      BlobStore blobStore = view.getBlobStore();
+      String containerName = getContainerName();
+      try {
+         File tempFile = File.createTempFile("prefix", "suffix");
+         tempFile.deleteOnExit();
+         RandomAccessFile raf = new RandomAccessFile(tempFile, "rw");
+         raf.setLength(length);
+         ByteSource byteSource = Files.asByteSource(tempFile);

Prefer `TestUtils.randomByteSource`.

> @@ -685,6 +686,32 @@ public void testPutMultipartInputStream() throws Exception {
       testPut(payload, null, new ByteSourcePayload(byteSource), length, new PutOptions().multipart(true));
    }
 
+   @Test(groups = { "integration", "live" })
+   public void testPutHugeObject() throws Exception {

We cannot add this to the general integration test group since it will explode run times.
 It looks like we have a "performance" group for this; could you use that tag instead?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1266#pullrequestreview-189469845
Mime
View raw message