jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Gaul <notificati...@github.com>
Subject Re: [jclouds/jclouds] Adding support for AWS S3 get_objects V2 api call. (#1267)
Date Tue, 15 Jan 2019 16:13:40 GMT
gaul requested changes on this pull request.

Can you add tests to `S3Test`, `ListBucketOptionsTest`, and `BucketsLiveTest`?

> @@ -37,6 +37,15 @@
 public class ListBucketOptions extends BaseHttpRequestOptions implements Cloneable {
    public static final ListBucketOptions NONE = new ListBucketOptions();
 
+   public ListBucketOptions withListType(String listType) {

Should this be `int` to match other getters and setters?

> @@ -37,6 +37,15 @@
 public class ListBucketOptions extends BaseHttpRequestOptions implements Cloneable {
    public static final ListBucketOptions NONE = new ListBucketOptions();
 
+   public ListBucketOptions withListType(String listType) {
+      queryParameters.put("list-type", checkNotNull(listType, "listType"));
+      return this;
+   }
+
+   public String getListType() {

Similarly, should this be `Integer` (matching `getMaxResults`)?

> @@ -28,13 +28,24 @@
    public ListContainerOptions apply(ListBucketOptions[] optionsList) {
       ListContainerOptions options = new ListContainerOptions();
       if (optionsList.length != 0) {
+         int listType = 1;
+         if (optionsList[0].getListType() != null && optionsList[0].getListType().equals("2"))
{

Prefer `Strings.nullToEmpty(optionsList[0].getListType()).equals("2")`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1267#pullrequestreview-192727568
Mime
View raw message