jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Gaul <notificati...@github.com>
Subject Re: [jclouds/jclouds] Adding support for AWS S3 get_objects V2 api call. (#1267)
Date Tue, 29 Jan 2019 06:51:51 GMT
gaul requested changes on this pull request.



>  
    public ListContainerOptions() {
    }
 
    ListContainerOptions(Integer maxKeys, String marker, String dir, boolean recursive,
-            boolean detailed, String prefix, String delimiter) {
+            boolean detailed, String prefix, String delimiter, int listType) {

Sorry I missed this earlier, but why does the portable abstraction need to know the S3 list
type?  This looks like a layering violation.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1267#pullrequestreview-197398732
Mime
View raw message