jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aliaksandra Kharushka <notificati...@github.com>
Subject Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)
Date Thu, 31 Jan 2019 12:16:33 GMT
ak58588 commented on this pull request.



> @@ -105,9 +111,28 @@ public HttpRequest signGetBlob(String container, String name, org.jclouds.blobst
       return sign("GET", container, name, blob2HttpGetOptions.apply(checkNotNull(options,
"options")),
             DEFAULT_EXPIRY_SECONDS, null, null);
    }
-
-   private HttpRequest sign(String method, String container, String name, @Nullable GetOptions
options, long expires, @Nullable Long contentLength, @Nullable String contentType) {
-      checkNotNull(method, "method");
+   
+   /**
+   * method to parse SAS string into components like st, se, sr etc.
+   *
+   */
+   public HashMap<String, String> refineSAS(String sas) {
+		HashMap<String, String> paramsMap = new HashMap<>();
+		String[] queryArray = sas.split("&");

removed this method, it's not used

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1270#discussion_r252644239
Mime
View raw message