jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [jclouds] nacx commented on a change in pull request #23: draft - disable AccessPolicy check for SAS Authorised azureblob
Date Wed, 24 Apr 2019 14:21:17 GMT
nacx commented on a change in pull request #23: draft - disable AccessPolicy check for SAS
Authorised azureblob
URL: https://github.com/apache/jclouds/pull/23#discussion_r278151052
 
 

 ##########
 File path: providers/azureblob/src/main/java/org/jclouds/azureblob/blobstore/functions/BlobPropertiesToBlobMetadata.java
 ##########
 @@ -58,6 +59,8 @@ public MutableBlobMetadata apply(BlobProperties from) {
             PublicAccess containerAcl = containerAcls.getUnchecked(from.getContainer());
             if (containerAcl != PublicAccess.PRIVATE)
                to.setPublicUri(from.getUrl());
+         } catch (UncheckedExecutionException ue) {
+               to.setPublicUri(from.getUrl());
 
 Review comment:
   Would something like the following work?
   ```java
   } catch (Exception ex) {
      InsufficientAccessRightsException iare = Throwables2.getFirstThrowableOfType(ex, InsufficientAccessRightsException.class);
      if (iare == null) throw ex; // Propagate any other uncaught exceptions
      to.setPublicUri(from.getUrl()); // handle our own exception gracefully
   }
   ``` 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message