jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [jclouds] gaul commented on a change in pull request #23: draft - disable AccessPolicy check for SAS Authorised azureblob
Date Sat, 27 Apr 2019 06:00:13 GMT
gaul commented on a change in pull request #23: draft - disable AccessPolicy check for SAS
Authorised azureblob
URL: https://github.com/apache/jclouds/pull/23#discussion_r279144562
 
 

 ##########
 File path: providers/azureblob/src/main/java/org/jclouds/azureblob/blobstore/functions/BlobPropertiesToBlobMetadata.java
 ##########
 @@ -58,6 +59,8 @@ public MutableBlobMetadata apply(BlobProperties from) {
             PublicAccess containerAcl = containerAcls.getUnchecked(from.getContainer());
             if (containerAcl != PublicAccess.PRIVATE)
                to.setPublicUri(from.getUrl());
+         } catch (UncheckedExecutionException ue) {
+               to.setPublicUri(from.getUrl());
 
 Review comment:
   Should this call `setPublicUri` when catching the exception?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message