jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [jclouds] nacx commented on a change in pull request #21: Adds methods listAll and listByLocation to VirtualMachineAPI
Date Tue, 14 May 2019 17:46:53 GMT
nacx commented on a change in pull request #21: Adds methods listAll and listByLocation to
VirtualMachineAPI
URL: https://github.com/apache/jclouds/pull/21#discussion_r283922598
 
 

 ##########
 File path: providers/azurecompute-arm/src/test/java/org/jclouds/azurecompute/arm/compute/AzureComputeServiceLiveTest.java
 ##########
 @@ -67,6 +75,30 @@ public void initializeContext() {
       }, Names.named(TIMEOUT_RESOURCE_DELETED)));
    }
 
+   @Test(dependsOnMethods = "testSuspendResume")
+   @Override
+   public void testListNodesByIds() {
+      final Set<String> nodeIds = copyOf(transform(nodes, new Function<NodeMetadata,
String>() {
+
+         @Override
+         public String apply(NodeMetadata from) {
+            return from.getId();
+         }
+
+      }));
+
+      final Set<? extends ComputeMetadata> listedNodes = client.listNodesByIds(nodeIds);
+
+      assertEquals(listedNodes.size(), nodes.size());
+
+      for (ComputeMetadata listedNode : listedNodes) {
 
 Review comment:
   This is an Azure particular behavior and I see no point in modifying a test that works
consistently across providers just for the Azure case-insensitive stuff. Let's override and
add a proper comment.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message