jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [jclouds] nacx commented on a change in pull request #30: Checks provisioning state in Rule resource instead of Group
Date Wed, 15 May 2019 05:06:33 GMT
nacx commented on a change in pull request #30: Checks provisioning state in Rule resource
instead of Group
URL: https://github.com/apache/jclouds/pull/30#discussion_r284087500
 
 

 ##########
 File path: providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/compute/extensions/AzureComputeSecurityGroupExtension.java
 ##########
 @@ -295,9 +295,10 @@ public boolean apply(NetworkSecurityRule input) {
       for (NetworkSecurityRule matchingRule : rules) {
          logger.debug(">> deleting network security rule %s from %s...", matchingRule.name(),
group.getName());
          ruleApi.delete(matchingRule.name());
-         checkState(
-               securityGroupAvailable.create(resourceGroupAndName.resourceGroup()).apply(networkSecurityGroup.name()),
-               "Security group was not updated in the configured timeout");
+         URI uri = api.getNetworkSecurityRuleApi(resourceGroupAndName.resourceGroup(), networkSecurityGroup.name()).delete(resourceGroupAndName.name());
 
 Review comment:
   This looks wrong:
   * The rule is already being deleted in line 297.
   * You are passing the security group name to the delete method, not the rule name.
   
   Remove this line, capture the URL in line 297 and check on that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message