jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ignasi Barrera (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (JCLOUDS-1166) Remove uses of the 'com.google.gson.internal' package
Date Thu, 09 May 2019 13:53:00 GMT

    [ https://issues.apache.org/jira/browse/JCLOUDS-1166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16836400#comment-16836400
] 

Ignasi Barrera commented on JCLOUDS-1166:
-----------------------------------------

Yes, we could, but we get back to my pervious point: jclouds-karaf is no longer owned by jclouds.
It is now an Apache Karaf project. So, given that this is *purely an OSGi issue*:

* If the fix we want is to just provide a custom bundle that ignores the original package,
that would probably live in jclouds-karaf and would have to be maintained by the Karaf community.
We can move ahead with the gson upgrade issue right now if we make this call, and defer to
the karaf community the responsibility to keep up to date with this jclouds usage of OSGi-unexported
stuff. (Anyone that wants to use jclouds in karaf will have to use our bundle and make sure
there are no conflicts). 
* If we really want to fix this in jclouds, we need to remove the usages of the offending
packages
** This change can be complex and sensitive, and I don't see us making it "in a timely manner".
** Copying the offending classes to our project allows us to move forward and upgrade nicely,
have close to zero impact on users and ecosystem, and gives us a clear and progressive deprecation
and removal plan.
** As I see it, the main risk in copying stuff is diverging from upstream, but we're just
keeping it as a compatibility layer (since we're already upgrading the dependency), and we
really don't care about those bits being in sync with upstream as we want to find an alternative
way to do the same thing, or to trim down the affected classes and extract just the behaviour
we need.

Thoughts?

> Remove uses of the 'com.google.gson.internal' package
> -----------------------------------------------------
>
>                 Key: JCLOUDS-1166
>                 URL: https://issues.apache.org/jira/browse/JCLOUDS-1166
>             Project: jclouds
>          Issue Type: Bug
>          Components: jclouds-chef, jclouds-core
>    Affects Versions: 1.9.2
>            Reporter: Ignasi Barrera
>            Priority: Major
>              Labels: gson
>
> Starting from Gson 2.6, the {{com.google.gson.internal}} packages are no longer exported
in the OSGi bundles. This makes it impossible to use jclouds in an OSGi environment if upgrading
to such versions of Gson.
> There is no change to add the exports back for that package (see [this discussion|https://github.com/google/gson/pull/916]),
so we should stop using those classes.
> See also: http://markmail.org/message/olgebygfgdy3hwtm



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message