jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [jclouds] nacx commented on a change in pull request #45: Add azure disk sku
Date Mon, 16 Sep 2019 16:17:21 GMT
nacx commented on a change in pull request #45: Add azure disk sku
URL: https://github.com/apache/jclouds/pull/45#discussion_r324764418
 
 

 ##########
 File path: providers/azurecompute-arm/src/test/java/org/jclouds/azurecompute/arm/features/DiskApiMockTest.java
 ##########
 @@ -78,6 +79,27 @@ public void createDiskWithTags() throws InterruptedException {
       assertTrue(dataDisk.tags().containsValue("jclouds-test-tag"));
    }
 
+   public void createDiskWithTagsAndSku() throws InterruptedException {
+
+      server.enqueue(jsonResponse("/creatediskwithtagsandskuresponse.json").setResponseCode(200));
+
+      final DiskApi diskApi = api.getDiskApi(resourcegroup);
+
+      DiskProperties properties = DiskProperties.builder().diskSizeGB(2).creationData(CreationData.create(CreationData.CreateOptions.EMPTY)).build();
+
+      DiskSku sku = DiskSku.builder().name("Premium_LRS").build();
 
 Review comment:
   Is there an enum of the existing valid Disk types?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message