jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <notificati...@github.com>
Subject Re: [jclouds/jclouds] JCLOUDS-1533 - Fix upload with SAS token when blob name contains slash (#1283)
Date Mon, 17 Feb 2020 11:21:40 GMT
nacx commented on this pull request.

Thanks for the fix!
This repository is deprecated, though. Could you update your fork and open the PR against
https://github.com/apache/jclouds ? Thanks!

> @@ -281,4 +284,19 @@ void appendUriPath(HttpRequest request, StringBuilder toSign) {
       }
    }
 
+   private String join(String[] parts, String delimiter) {

Can you use the Guava `Joiner` instead?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1283#pullrequestreview-359663568
Mime
View raw message