jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [jclouds] geomacy commented on pull request #78: Replace embedded and repackaged GSON library
Date Thu, 22 Oct 2020 19:13:06 GMT

geomacy commented on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-714704006


   > Should I do a rebase and squash?
   
   Just a suggestion, I think it's easier to follow the history and comments if it is just
left as-is.  But I don't know what the conventions are in jclouds.  Perhaps a squash once
everything is approved?
   
   Regarding questions [above](https://github.com/apache/jclouds/pull/78#issuecomment-711058485)
   
   > The main area of concern is the way Apache JClouds is used within Apache Brooklyn?
   > At compile time, runtime or both?
   
   I would say both. I would share Alex's [concern](https://lists.apache.org/thread.html/r0c1f7bf4c58e6447d145245c8d24de8c05b7787f2b0efb44459bba9a%40%3Cdev.jclouds.apache.org%3E)
that Gson 2.8.6 may cause us problems, particularly because of the [issues](https://lists.apache.org/thread.html/r64449ba3747ed3a400725f4fa5bb107680aad067bf13a236253beaf1%40%3Cdev.jclouds.apache.org%3E)
Robert points out. Also it seems, iiuc, that if this gets merged then there would be downstream
changes required in jclouds-karaf, which we would then need to integrate in turn. Your suggestion
of automatic feature generation sounds interesting but would require considerable further
work, wouldn't it? 
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message