jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [jclouds] gaul commented on pull request #78: Replace embedded and repackaged GSON library
Date Thu, 22 Oct 2020 23:46:06 GMT

gaul commented on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-714821651


   I would like to push this review forward.  While I do not understand all the OSGi issues,
if they can be resolved by jclouds-karaf making code changes then this should not block the
main jclouds code evolution.  Regarding gson 2.8.6 specifically, it seems that google/gson#1601
would block a lot of users?  Would using 2.8.5 temporarily be OK?
   
   @gurkerl83 It is fine to have multiple commits merge in a single PR.  If squashing these
makes it easier for a future contributor then please do so, but include the detailed description
that you already wrote!
   
   @nacx what do you think?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message