jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [jclouds] gurkerl83 commented on pull request #78: Replace embedded and repackaged GSON library
Date Fri, 23 Oct 2020 10:06:17 GMT

gurkerl83 commented on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-715242490

   Thanks for the feedback!
   I will leave this feature as it is. I suggest we do not do any squashing to see the respective
commits' changes as they appeared; otherwise, it might be harder to comprehend the steps later.
   @ahgittin GSON 2.8.5 vs. 2.8.6 - In the OSGi metadata configuration of version 2.8.6, the
field require-capability gets generated by the JDK used in the compilation of the library.
On the GSON master branch, this field gets predefined in the bnd file to a lower version than
version 9, so it can not be overwritten in the library's compilation; only the forthcoming
version 2.8.7 works that way. 
   In the JClouds Core module, the original GSON library gets embedded (with the original
/ wrongly configured OSGi metadata file). This does not matter. The OSGi runtime does not
interpret this embedded library; otherwise, it would see the limited exports we are trying
to fix. Only the JClouds core bundle's OSGi metadata gets analyzed, which also generates its
required compatibility flag during compilation. Using JDK 8, it produces the following entry,
which is fine.
   ```Require-Capability: osgi.ee;filter:="(&(osgi.ee=JavaSE)(version=1.8))"``` 
   My estimation of using a secondary library of GSON in an OSGi stacked application is to
pin its version to 2.8.5 in a JDK 8 environment.

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:

View raw message