jclouds-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [jclouds] gurkerl83 commented on pull request #78: Replace embedded and repackaged GSON library
Date Sat, 24 Oct 2020 20:27:23 GMT

gurkerl83 commented on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-716050796


   @geomacy Sorry about the misleading wording. You are right, the only thing that is happening
is a re-export of GSON packages, nothing more. The footnote of yours in response to my estimation
is in a practical environment much harder to validate. I think OSGi implementations are not
perfect, especially in edge cases like that.
   
   I changed my opinion about which version of GSON we should use in this feature, to make
sure we really introduce no side effects on a JDK level. We should go with 2.8.5. Anyway,
I would like to introduce a conditional build profile to support JDK 11 and above, here we
could then easily set GSON to the 2.8.6 version.
   
   We are not at the finished line, yet. During my latest experiments with the latest version
JClouds from the master branch, we might get a problem with the current Guice of version 4.2.3
in use.
   
   https://github.com/apache/jclouds/commit/31a3e5b5df1543d04098e3a694130b7ae8e6e079
   
   Guice 4.2.3 requires a minimal Guava version of 27.1-jre and this is also what my OSGi
feature builder is complaining about.
   https://mvnrepository.com/artifact/com.google.inject/guice/4.2.3
   
   Luckily the JClouds sources are already compatible with at least guava 29 when the comment
in the commit is correct. 
   https://github.com/apache/jclouds/commit/62767a14610fc1c97c440dbd5ee0f02b276a1069
   
   I think we have to address this in an additional, much smaller feature, I will open for
discussion tomorrow, maybe a JIRA ticket is required also.
   
   Thx!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message