jclouds-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ignasi Barrera <n...@apache.org>
Subject Re: Softlayer GlobalIdentifier question
Date Wed, 03 Sep 2014 17:48:43 GMT
Ah, right. The SoftLayer provider was modernized in our last 1.8 release.
Could you try upgrading and share what you find out?

Thanks!

I.
El 03/09/2014 19:40, "Jai M" <jaiganesh.m@gmail.com> escribió:

> Thanks Ignasi for getting back on this. I was looking at the master branch
> code to see if I can fix it. However the SoftLayerComputeServiceAdapter
> class has been revamped now. I don not see the globalIdentifier being used
> anymore.
> I will try out with the latest code.
>
> Rgds
> Jai
>
>
> On Sun, Aug 31, 2014 at 7:32 AM, Ignasi Barrera <nacx@apache.org> wrote:
>
>> Hi Jai,
>>
>> Thanks for sharing and figuring out the cause of your issue.
>>
>> Could you please open a JIRA issue [1] so we can track this?
>>
>> And could you send your changes as a pull request [2]? This way we'll be
>> able to review and test it before merging. Patches and pull request are
>> very welcome!
>>
>> Thanks!
>>
>> I.
>>
>> [1] https://issues.apache.org/jira/browse/JCLOUDS
>> [2] http://wiki.apache.org/jclouds/How%20to%20Contribute
>> El 28/08/2014 16:23, "Jai M" <jaiganesh.m@gmail.com> escribió:
>>
>> Hi,
>>>
>>>    I am trying out the Softlayer adapter in 1.8.x release. While
>>> creating a virtual guest with method createNodeWithGroupEncodedIntoName, I
>>> get a validation error that the globalIdentifier is null. The problem was
>>> that, the private images that I have in softlayer have globalIdentifier as
>>> null. However they all have an Id.
>>>
>>> Why is the adapter code looking for the global identifier if the private
>>> images can have it as null ?
>>> Only after I changed the SoftLayerComputeServiceAdapter code to look for
>>> id instead of globalIdentifier, I was able to proceed.
>>>
>>> Changed line 354 from
>>>
>>>  final String globalIdentifier = "" + image.getGlobalIdentifier();
>>>
>>> to
>>>
>>>  final String globalIdentifier = "" + image.getId();
>>>
>>> Let me know if this is good and if can be incorporated.
>>>
>>> Rgds
>>> Jai
>>>
>>
>

Mime
View raw message