jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Philippe Mouawad <philippe.moua...@gmail.com>
Subject Re: DO NOT REPLY [Bug 52997] Jmeter should not exit without saving Test Plan if saving before exit fails
Date Tue, 24 Apr 2012 20:58:18 GMT
Hello,
Note that I am on a Mac OSX.
I am testing on trunk.

Regards
Philippe

On Tue, Apr 24, 2012 at 10:15 PM, sebb <sebbaz@gmail.com> wrote:

> On 24 April 2012 20:08, Philippe Mouawad <philippe.mouawad@gmail.com>
> wrote:
> > IN fact it happens If I use shortcut but not if I use menu on Mac OSX.
> >
> > On Tue, Apr 24, 2012 at 9:05 PM, Philippe Mouawad <
> > philippe.mouawad@gmail.com> wrote:
> >
> >> I think I didn't test correctly, in fact to simulate failure I threw an
> >> exception in code before this test, that's why I failed detecting it.
>
> I made the test plan read-only for testing.
>
> >> And yes , it seems I haven't created any test plan since yesterday :-) ,
> >> by lack of chance I am creating a Test Plan but using an already created
> >> one.
> >>
> >> So I have the same result as you on canRead / canWrite.
> >>
>
> OK, useful to know.
>
> >> By the way I noticed the following strange behaviour related to save
> >> (which seems to exist also in 2.6):
> >>
> >>    - Start JMeter
> >>    - Add Thread Group and other Test Eleemnt
> >>    - Quit
> >>    - JMeter does not ask you to save, shouldn't be so ?
>
> I don't get the same behvaiour in the current SVN code.
>
> >>
> >> Regards
> >>
> >> Philippe
> >>
> >> On Tue, Apr 24, 2012 at 8:07 PM, sebb <sebbaz@gmail.com> wrote:
> >>
> >>> On 24 April 2012 18:09, Philippe Mouawad <philippe.mouawad@gmail.com>
> >>> wrote:
> >>> > As you always say, good catch :-)
> >>> > And sorry for being too hasty on this fix.
> >>>
> >>> No problem.
> >>>
> >>> I'm just a bit surprised you did not notice the problem, unless
> >>> canWrite() behaves differently for your (or you did not create any new
> >>> plans yet!).
> >>>
> >>> > Regards
> >>> > Philippe
> >>> >
> >>> > On Tue, Apr 24, 2012 at 2:38 PM, <bugzilla@apache.org> wrote:
> >>> >
> >>> >> https://issues.apache.org/bugzilla/show_bug.cgi?id=52997
> >>> >>
> >>> >> --- Comment #3 from Sebb <sebb@apache.org> 2012-04-24 12:38:21
UTC
> ---
> >>> >> Fixed in SVN:
> >>> >>
> >>> >> URL: http://svn.apache.org/viewvc?rev=1329669&view=rev
> >>> >> Log:
> >>> >> Bug 52997 - Jmeter should not exit without saving Test Plan if
> saving
> >>> >> before
> >>> >> exit fails
> >>> >>
> >>> >> Modified:
> >>> >>   jmeter/trunk/src/core/org/apache/jmeter/gui/action/Save.java
> >>> >>
> >>> >>
> >>> >> Note: I removed the setDirty(true) method call and the clearing
of
> the
> >>> file
> >>> >> name.
> >>> >> Failure to save the file should not affect the dirty status.
> >>> >> Clearing the filename does not really achieve anything.
> >>> >>
> >>> >> Leaving the issue open for now, in case there are further problems.
> >>> >>
> >>> >> --
> >>> >> Configure bugmail:
> >>> >> https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
> >>> >> ------- You are receiving this mail because: -------
> >>> >> You are the assignee for the bug.
> >>> >>
> >>> >
> >>> >
> >>> >
> >>> > --
> >>> > Cordialement.
> >>> > Philippe Mouawad.
> >>>
> >>
> >>
> >>
> >> --
> >> Cordialement.
> >> Philippe Mouawad.
> >>
> >>
> >>
> >>
> >
> >
> > --
> > Cordialement.
> > Philippe Mouawad.
>



-- 
Cordialement.
Philippe Mouawad.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message