jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Milamber <milam...@apache.org>
Subject Re: [VOTE] Release JMeter 2.8 RC1
Date Tue, 02 Oct 2012 06:45:40 GMT
On Sun, Sep 30, 2012 at 3:24 PM, Rainer Jung <rainer.jung@kippdata.de>wrote:

> On 30.09.2012 12:39, Milamber wrote:
>
>> [XX] +1  I support this release
>>
>
> +1 for release, thanks for RM!
>
> Details:
>
> - MD5 OK
> - signatures OK
> - key in KEYS file
>
> - gz and zip for src and bin consistent except for:
>   - heapdump.cmd and heapdump.sh in bin directory of svn,
>     missing from gz and zip binary releases
>   - heapdump.sh in src gz, neither heapdump.sh
>     nor heapdump.cmd in src zip
>



Related to:

Author: sebb
Date: Thu Aug 30 18:44:40 2012
New Revision: 1379054

URL: http://svn.apache.org/viewvc?rev=1379054&view=rev
Log:
Add support for HeapDump to the JMeter non-GUI client


===

[X] -0   OK, but....

I thinks we need fix this issue, and restart a RC2. Otherwise the new
functionality heapdump can't be use in binary archives.

If everybody is ok, I will restart the RC2 tonight.


===

The fix is:
Index: build.xml
===================================================================
--- build.xml    (revision 1392754)
+++ build.xml    (working copy)
@@ -1208,6 +1208,7 @@
     <include name="${dest.jar.jmeter}/mirror-server.*"/>
     <include name="${dest.jar.jmeter}/shutdown.*"/>
     <include name="${dest.jar.jmeter}/stoptest.*"/>
+      <include name="${dest.jar.jmeter}/heapdump.*"/>
     <!-- Fake SSL cert for JMeter proxy recorder in https -->
     <include name="${dest.jar.jmeter}/proxyserver.jks"/>
     <!-- Exclude any files that might be present from testing the release
-->




>
> - builds fine
>
> - build result looks consistent with distribution, except for
>   - timestamps in generated javadoc (expected)
>   - binary jar files (expected)
>   - heapdump.sh
>
> - no Javadoc warnings
>
> - ran the tests (but only with java.awt.headless)
>
> - I have not checked the staging repository.
>
> Build and tests were done using Java 1.5.0_22, OS was Solaris 10 Sparc.
>
> Regards,
>
> Rainer
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message