jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r1402574 - /jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
Date Mon, 29 Oct 2012 00:54:26 GMT
On 26 October 2012 18:04,  <milamber@apache.org> wrote:
> Author: milamber
> Date: Fri Oct 26 17:04:00 2012
> New Revision: 1402574
>
> URL: http://svn.apache.org/viewvc?rev=1402574&view=rev
> Log:
> When used the options Retrieve All Embedded Resources + Concurrent pool, these log.warn()
generates a lot of lines in jmeter.log.
>
> Modified:
>     jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java

-1, see below.

> Modified: jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
> URL: http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java?rev=1402574&r1=1402573&r2=1402574&view=diff
> ==============================================================================
> --- jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
(original)
> +++ jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
Fri Oct 26 17:04:00 2012
> @@ -753,7 +753,7 @@ public abstract class HTTPSamplerBase ex
>
>      public void setAuthManager(AuthManager value) {
>          AuthManager mgr = getAuthManager();
> -        if (mgr != null) {
> +        if (log.isDebugEnabled() && mgr != null) {
>              log.warn("Existing AuthManager " + mgr.getName() + " superseded by " + value.getName());

I'm not very happy with this fix, as it suppresses the warnings when
Concurrent pool is not in use.
It also presumably does not display valid warnings if concurrent pool is in use.

I've not looked at the code yet, but there has to be a better way to do this.
Ideally change the pool code so it does not generate the overrides.

Also, the code looks odd - why check for debug yet report a warning?

>          }
>          setProperty(new TestElementProperty(AUTH_MANAGER, value));
> @@ -783,7 +783,7 @@ public abstract class HTTPSamplerBase ex
>
>      public void setCookieManager(CookieManager value) {
>          CookieManager mgr = getCookieManager();
> -        if (mgr != null) {
> +        if (log.isDebugEnabled() && mgr != null) {
>              log.warn("Existing CookieManager " + mgr.getName() + " superseded by " +
value.getName());
>          }
>          setProperty(new TestElementProperty(COOKIE_MANAGER, value));
> @@ -795,7 +795,7 @@ public abstract class HTTPSamplerBase ex
>
>      public void setCacheManager(CacheManager value) {
>          CacheManager mgr = getCacheManager();
> -        if (mgr != null) {
> +        if (log.isDebugEnabled() && mgr != null) {
>              log.warn("Existing CacheManager " + mgr.getName() + " superseded by " +
value.getName());
>          }
>          setProperty(new TestElementProperty(CACHE_MANAGER, value));
>
>

Mime
View raw message