jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Philippe Mouawad <philippe.moua...@gmail.com>
Subject Re: A patch for TCP Sampler
Date Sat, 01 Dec 2012 09:31:31 GMT
Hello,
Maybe We could replace checkbox by select box
- blank (not set)
- true
- false
This would allow clear override

We would need to ensure it works with current test plans.

Regards
Philippe
On Saturday, December 1, 2012, Kurt Hong wrote:

> Great thanks for your kind help:-)
>
> The reason why I was thinking of removing "Re-Use Connection" checkbox and
> so on from one of them is...
>
> In case checkboxes, If user utilizes TCP Sampler and TCP Sampler Config
> together, the settings on the TCP Sampler Config are meaningless.
>
> So now I'm thinking of placing options like shown below...
>
> TCP Sampler
> - Re-Use Connection
> - Close Connection
>
> TCP Sampler Config
> - TCP Nodelay
> - SO_LINGER, LINGER Timeout
> - End of line(EOL) byte value
>
> We can remove at least Re-Use Connection checkbox on TCP Sampler Config as
> it was not working already.
>
> Now the thing is where we will place TCP Nodelay checkbox or should we
> keep that meaningless checkbox on both of them for backward compatibility?
> Or we can just place TCP Nodelay checkbox only on TCP Sampler.
>
> Give me your great idea!
>
> Thanks again!
>
> Sent from my iPhone
>
> On 1 Dec 2012, at 05:18, "Philippe Mouawad" <philippe.mouawad@gmail.com<javascript:;>>
> wrote:
>
> > Hello,
> > Thanks for proposal, see my answers below.
> >
> > Regards
> > Philippe
> >
> > On Friday, November 30, 2012, Kurt Hong wrote:
> >
> >> Dear apache jmeter developers,
> >>
> >> I'm warring if these questions would make you feel like a burden as I'm
> >> not familiar with open source committing process. I’m reading most of
> your
> >> documents though. If you advise several URL or document, that would be
> very
> >> helpful too.
> >>
> >> Questions,
> >> 1.      Once I make a path following
> >> http://wiki.apache.org/jmeter/CommittingChanges page, how can I commit
> >> that? I mean, can I commit that without svn account? As anonymous
> account?
> >
> > Only commiters can commit, so you need to create a patch
> >
> >> 2.      Or should I discuss enough here in this mailing list before
> make a
> >> commit?
> >
> > Yes
> >
> >> 3.      In case of modification of documents, in below case,
> modification
> >> of Component Reference.xml is enough? And xUnit test case is mandatory?
> >>
> >> The more you do, the better it is :)
> >
> >
> >> I made a patch about TCP Sampler and TCP Sampler Config like shown
> below.
> >>        On TCP Sampler Config
> >> -       Add “SO_LINGER” checkbox and “LINGER Timeout” text input box
to
> >> prevent large numbers of sockets sitting around with a TIME_WAIT status.
> >> It’s related to
> https://issues.apache.org/bugzilla/show_bug.cgi?id=40499
> >> -       Add “End of line(EOL) byte value” text input box to set eolByte
> >> value on GUI. Setting on GUI will overwrite the setting in properties
> file.
> >> If user doesn’t set the value on GUI, It will use the setting on
> properties
> >> file.
> >>
> >> On TCP Sampler
> >> -       Add “Close Connection” checkbox to be able to close connection
> >> even if user checks “Re-Use Connection” option. In our company’s test,
> we
> >> needed to close the connection at the end of each thread
> >>
> >> Also, I’m thinking of moving all checkboxes on TCP Sampler into TCP
> >> Sampler Config or Removing “Re-Use Connection” and “Close Connection”
> >> checkboxes from TCP Sampler.
> >>
> >> Think about backward compatibility when creating you patch, so you
> should
> > not remove existing configuration options and existing jmx must be
> readable
> > after your patch is applied.
> >
> > And this patch was originally made for our company’s testing.
> >>
> >> Thank you!
> >
> >
> > --
> > Cordialement.
> > Philippe Mouawad.
>


-- 
Cordialement.
Philippe Mouawad.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message