jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Philippe Mouawad <philippe.moua...@gmail.com>
Subject Re: [Bug 55432] CSV Dataset Config loses sharing mode when switching languages
Date Tue, 20 Aug 2013 21:53:31 GMT
I think I have fixed it, please review to double check.

Thanks


On Tue, Aug 20, 2013 at 11:08 PM, sebb <sebbaz@gmail.com> wrote:

> On 20 August 2013 21:16, Philippe Mouawad <philippe.mouawad@gmail.com>
> wrote:
> > Regarding the bug, there is something I don't clearly understand in
> > PropertyEditorSupport subclass , why does FieldStringEditor implement
> > FocusListener and not ComboStringEditor ?
> >
> > Do you know why ?
>
> Sorry, no.
>
> >
> > On Tue, Aug 20, 2013 at 5:12 PM, sebb <sebbaz@gmail.com> wrote:
> >
> >> On 20 August 2013 13:11, Philippe Mouawad <
> p.mouawad@ubik-ingenierie.com>
> >> wrote:
> >> > Hello Sebb,
> >> > I don't think you broke it, I made some checks and it seems it is
> broken
> >> in
> >> > versions before your change.
> >>
> >> OK, however I think I did do some damage to ComboStringEditor when I
> >> changed the static EDIT and UNDEFINED fields to instance variables -
> >> the code relied on '==' comparisons which won't work with instance
> >> variables. I'll fix that shortly.
> >>
> >> > Could be related to:
> >> > https://issues.apache.org/bugzilla/show_bug.cgi?id=55103
> >>
> >> Yes, looks quite likely.
> >>
> >> > Regards
> >> >
> >> >
> >> > On Tue, Aug 20, 2013 at 12:10 AM, <bugzilla@apache.org> wrote:
> >> >
> >> >> https://issues.apache.org/bugzilla/show_bug.cgi?id=55432
> >> >>
> >> >> Sebb <sebb@apache.org> changed:
> >> >>
> >> >>            What    |Removed                     |Added
> >> >>
> >> >>
> >>
> ----------------------------------------------------------------------------
> >> >>              Status|REOPENED                    |RESOLVED
> >> >>          Resolution|---                         |FIXED
> >> >>
> >> >> --- Comment #5 from Sebb <sebb@apache.org> ---
> >> >> It's not just CSV Dataset - JSR223 Preproces has the same issue.
> >> >>
> >> >> Looks like I broke ComboStringEditor while implementing Bug 55440
> >> >>
> >> >> I'll close this and re-open that.
> >> >>
> >> >> --
> >> >> You are receiving this mail because:
> >> >> You are on the CC list for the bug.
> >> >> You are watching the reporter of the bug.
> >> >>
> >> >
> >> >
> >> >
> >> > --
> >> > Cordialement.
> >> > Philippe Mouawad.
> >> > Ubik-Ingénierie
> >> >
> >> > UBIK LOAD PACK Web Site <http://www.ubikloadpack.com/>
> >> >
> >> > UBIK LOAD PACK on TWITTER <https://twitter.com/ubikloadpack>
> >>
> >
> >
> >
> > --
> > Cordialement.
> > Philippe Mouawad.
>



-- 
Cordialement.
Philippe Mouawad.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message