jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Philippe Mouawad <philippe.moua...@gmail.com>
Subject Re: svn commit: r1611965 - /jmeter/trunk/test/src/org/apache/jmeter/protocol/http/modifier/TestURLRewritingModifier.java
Date Tue, 22 Jul 2014 18:01:21 GMT
Hello Sebb,
No because the fix I made on test was a fix on 2 tests I added for this
feature.
All existing tests ran fine.

It was a bug in my test which I fixed.

Regards

On Tuesday, July 22, 2014, sebb <sebbaz@gmail.com> wrote:

> On 19 July 2014 22:05,  <pmouawad@apache.org <javascript:;>> wrote:
> > Author: pmouawad
> > Date: Sat Jul 19 21:04:59 2014
> > New Revision: 1611965
> >
> > URL: http://svn.apache.org/r1611965
> > Log:
> > Bug 41319 - URLRewritingModifier : Allow Parameter value to be url
> encoded
> > Fix test error
>
> -1
>
> This is not a test error.
> The test should not have been affected by the addition of the encode?
> option.
>
> Please revert this change and fix the code so it is compatible with
> previous versions.
>
> > Bugzilla Id: 41319
> >
> > Modified:
> >
> jmeter/trunk/test/src/org/apache/jmeter/protocol/http/modifier/TestURLRewritingModifier.java
> >
> > Modified:
> jmeter/trunk/test/src/org/apache/jmeter/protocol/http/modifier/TestURLRewritingModifier.java
> > URL:
> http://svn.apache.org/viewvc/jmeter/trunk/test/src/org/apache/jmeter/protocol/http/modifier/TestURLRewritingModifier.java?rev=1611965&r1=1611964&r2=1611965&view=diff
> >
> ==============================================================================
> > ---
> jmeter/trunk/test/src/org/apache/jmeter/protocol/http/modifier/TestURLRewritingModifier.java
> (original)
> > +++
> jmeter/trunk/test/src/org/apache/jmeter/protocol/http/modifier/TestURLRewritingModifier.java
> Sat Jul 19 21:04:59 2014
> > @@ -118,7 +118,7 @@ public class TestURLRewritingModifier ex
> >              context.setPreviousResult(response);
> >              mod.process();
> >              Arguments args = sampler.getArguments();
> > -            assertEquals("bonjour+monsieur", ((Argument)
> args.getArguments().get(0).getObjectValue())
> > +            assertEquals("bonjour monsieur", ((Argument)
> args.getArguments().get(0).getObjectValue())
> >                      .getValue());
> >              assertEquals("http://server.com/index.html?" +
> "session_id=bonjour+monsieur", sampler.toString());
> >          }
> >
> >
>


-- 
Cordialement.
Philippe Mouawad.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message