jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r1614878 - /jmeter/trunk/src/protocol/mail/org/apache/jmeter/protocol/smtp/sampler/protocol/SendMailCommand.java
Date Thu, 31 Jul 2014 14:26:12 GMT
On 31 July 2014 14:32, Philippe Mouawad <philippe.mouawad@gmail.com> wrote:
> This one for example:
> - https://issues.apache.org/bugzilla/show_bug.cgi?id=56682

That bug is far too vague.
It's not clear which of the reported bugs really re bugs and which are
false-positives.
I don't intend to work through them all to classify them.

IMO, adding that bug reference to the commit message would not really help.

But if there are some specific bugs that are relevant, then of course
the log message can be updated and the summary added to the bug
comments.

Not all code changes need corresponding bug ids.
For example, spelling mistakes. Removal of tabs. Correcting alignment.

In this case, I think the changes are border-line, which is why I did
not bother creating a bug.

> Regards
>
> On Thursday, July 31, 2014, sebb <sebbaz@gmail.com> wrote:
>
>> On 31 July 2014 14:00, Philippe Mouawad <philippe.mouawad@gmail.com
>> <javascript:;>> wrote:
>> > Hello,
>> > All these commits should be grouped and related to the bugzilla id we
>> have.
>>
>> What bug is that?
>>
>> > Regards
>> > Philippe
>> >
>> > On Thursday, July 31, 2014, <sebb@apache.org <javascript:;>> wrote:
>> >
>> >> Author: sebb
>> >> Date: Thu Jul 31 12:58:10 2014
>> >> New Revision: 1614878
>> >>
>> >> URL: http://svn.apache.org/r1614878
>> >> Log:
>> >> Use more specific Exception classes
>> >>
>> >> Modified:
>> >>
>> >>
>> jmeter/trunk/src/protocol/mail/org/apache/jmeter/protocol/smtp/sampler/protocol/SendMailCommand.java
>> >>
>> >> Modified:
>> >>
>> jmeter/trunk/src/protocol/mail/org/apache/jmeter/protocol/smtp/sampler/protocol/SendMailCommand.java
>> >> URL:
>> >>
>> http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/mail/org/apache/jmeter/protocol/smtp/sampler/protocol/SendMailCommand.java?rev=1614878&r1=1614877&r2=1614878&view=diff
>> >>
>> >>
>> ==============================================================================
>> >> ---
>> >>
>> jmeter/trunk/src/protocol/mail/org/apache/jmeter/protocol/smtp/sampler/protocol/SendMailCommand.java
>> >> (original)
>> >> +++
>> >>
>> jmeter/trunk/src/protocol/mail/org/apache/jmeter/protocol/smtp/sampler/protocol/SendMailCommand.java
>> >> Thu Jul 31 12:58:10 2014
>> >> @@ -261,7 +261,7 @@ public class SendMailCommand {
>> >>       * Sends message to mailserver, waiting for delivery if using
>> >> synchronous mode.
>> >>       *
>> >>       * @param message
>> >> -     *            Message prior prepared by prepareMessage()
>> >> +     *            Message previously prepared by prepareMessage()
>> >>       * @throws MessagingException
>> >>       * @throws IOException
>> >>       * @throws InterruptedException
>> >> @@ -298,9 +298,11 @@ public class SendMailCommand {
>> >>      /**
>> >>       * Processes prepareMessage() and execute()
>> >>       *
>> >> -     * @throws Exception
>> >> +     * @throws InterruptedException
>> >> +     * @throws IOException
>> >> +     * @throws MessagingException
>> >>       */
>> >> -    public void execute() throws Exception {
>> >> +    public void execute() throws MessagingException, IOException,
>> >> InterruptedException {
>> >>          execute(prepareMessage());
>> >>      }
>> >>
>> >>
>> >>
>> >>
>> >
>> > --
>> > Cordialement.
>> > Philippe Mouawad.
>>
>
>
> --
> Cordialement.
> Philippe Mouawad.

Mime
View raw message