jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r1607182 - /jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java
Date Wed, 02 Jul 2014 10:05:36 GMT
On 1 July 2014 21:39,  <pmouawad@apache.org> wrote:
> Author: pmouawad
> Date: Tue Jul  1 20:39:57 2014
> New Revision: 1607182
>
> URL: http://svn.apache.org/r1607182
> Log:
> Fix typo

-1, please revert.

> Modified:
>     jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java
>
> Modified: jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java
> URL: http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java?rev=1607182&r1=1607181&r2=1607182&view=diff
> ==============================================================================
> --- jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java
(original)
> +++ jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java
Tue Jul  1 20:39:57 2014
> @@ -525,7 +525,7 @@ public class HTTPHC4Impl extends HTTPHCA
>           */
>          public HttpClientKey(URL url, boolean hasProxy, String proxyHost,
>                  int proxyPort, String proxyUser, String proxyPass) {
> -            // N.B. need to separate protocol from authority otherwise http://server
would match https://erver
> +            // N.B. need to separate protocol from authority otherwise http://server
would match https://server

The original version was correct - "httpserver" would match
http://server and https://erver if the fields were just concatenated.

Perhaps add "(sic)" at the end of the line to make it clear, thus:

// N.B. need to separate protocol from authority otherwise
http://server would match https://erver (sic)

>              // could use separate fields, but simpler to combine them
>              this.target = url.getProtocol()+"://"+url.getAuthority();
>              this.hasProxy = hasProxy;
>
>

Mime
View raw message