jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Felix Schumacher <felix.schumac...@internetallee.de>
Subject Re: svn commit: r1687926 - /jmeter/trunk/src/components/org/apache/jmeter/extractor/HtmlExtractor.java
Date Sat, 27 Jun 2015 14:52:58 GMT


Am 27. Juni 2015 16:06:54 MESZ, schrieb pmouawad@apache.org:
>Author: pmouawad
>Date: Sat Jun 27 14:06:54 2015
>New Revision: 1687926
>
>URL: http://svn.apache.org/r1687926
>Log:
>Add more infos on errors
>
>Modified:
>jmeter/trunk/src/components/org/apache/jmeter/extractor/HtmlExtractor.java
>
>Modified:
>jmeter/trunk/src/components/org/apache/jmeter/extractor/HtmlExtractor.java
>URL:
>http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/extractor/HtmlExtractor.java?rev=1687926&r1=1687925&r2=1687926&view=diff
>==============================================================================
>---
>jmeter/trunk/src/components/org/apache/jmeter/extractor/HtmlExtractor.java
>(original)
>+++
>jmeter/trunk/src/components/org/apache/jmeter/extractor/HtmlExtractor.java
>Sat Jun 27 14:06:54 2015
>@@ -91,7 +91,7 @@ public class HtmlExtractor extends Abstr
>         if (previousResult == null) {
>             return;
>         }
>-        log.debug("HtmlExtractor processing result");
>+        log.debug("HtmlExtractor "+getName()+":processing result");
> 
>         // Fetch some variables
>         JMeterVariables vars = context.getVariables();
>@@ -116,7 +116,7 @@ public class HtmlExtractor extends Abstr
>                 try {
>                     prevCount = Integer.parseInt(prevString);
>                 } catch (NumberFormatException e1) {
>-                    log.warn("Could not parse "+prevString+" "+e1);
>+                    log.warn(getName()+":Could not parse
>"+prevString+" "+e1);

I prefer to get a stacktrace instead of a simple String of the error. 

Do we have a general guide line with respect to this? 

Regards, 
Felix
>                 }
>             }
>          int matchCount=0;// Number of refName_n variable sets to keep
>@@ -145,11 +145,11 @@ public class HtmlExtractor extends Abstr
>                     vars.remove(refName_n);
>                 }
>             } catch (RuntimeException e) {
>-                log.warn("Error while generating result");
>+                log.warn(getName()+":Error while generating result");
>             }
> 
>         } catch (RuntimeException e) {
>-            log.warn("Error while generating result");
>+            log.warn(getName()+":Error while generating result");
>         }
> 
>     }


Mime
View raw message