jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Felix Schumacher <felix.schumac...@internetallee.de>
Subject Re: svn commit: r1708135 - in /jmeter/trunk: build.xml eclipse.classpath test/resources/
Date Mon, 12 Oct 2015 17:33:06 GMT
Am 12.10.2015 um 18:55 schrieb sebb:
> On 12 October 2015 at 15:56,  <fschumacher@apache.org> wrote:
>> Author: fschumacher
>> Date: Mon Oct 12 14:56:30 2015
>> New Revision: 1708135
>>
>> URL: http://svn.apache.org/viewvc?rev=1708135&view=rev
>> Log:
>> Add a directory for resources used by tests/unit cases to classpath in the
>> _test target and the eclipse class path.
>>
>> Added:
>>      jmeter/trunk/test/resources/
>> Modified:
>>      jmeter/trunk/build.xml
>>      jmeter/trunk/eclipse.classpath
>>
>> Modified: jmeter/trunk/build.xml
>> URL: http://svn.apache.org/viewvc/jmeter/trunk/build.xml?rev=1708135&r1=1708134&r2=1708135&view=diff
>> ==============================================================================
>> --- jmeter/trunk/build.xml (original)
>> +++ jmeter/trunk/build.xml Mon Oct 12 14:56:30 2015
>> @@ -263,6 +263,7 @@
>>     <property name="build.mongodb" value="build/protocol/mongodb"/>
>>     <property name="build.test" value="build/test"/>
>>     <property name="build.res" value="build/res"/>
>> +  <property name="build.test-res" value="test/resources"/>
>>
>>     <!-- Path prefix to allow Anakia to find stylesheets if running under Eclipse
-->
>>     <!--
>> @@ -2607,6 +2608,7 @@ run JMeter unless all the JMeter jars ar
>>           <fileset dir="${dest.jar.jmeter}" includes="ApacheJMeter.jar"/>
>>           <fileset dir="${dest.jar}" includes="*.jar"/>
>>           <pathelement location="${build.test}"/>
>> +        <pathelement location="${build.test-res}"/>
>>           <path refid="classpath"/>
>>         </classpath>
>>         <jvmarg value="-server"/>
>>
>> Modified: jmeter/trunk/eclipse.classpath
>> URL: http://svn.apache.org/viewvc/jmeter/trunk/eclipse.classpath?rev=1708135&r1=1708134&r2=1708135&view=diff
>> ==============================================================================
>> --- jmeter/trunk/eclipse.classpath (original)
>> +++ jmeter/trunk/eclipse.classpath Mon Oct 12 14:56:30 2015
>> @@ -98,6 +98,7 @@
>>          <classpathentry kind="lib" path="lib/xpp3_min-1.1.4c.jar"/>
>>          <classpathentry kind="lib" path="lib/xstream-1.4.8.jar"/>
>>          <!-- Needed for build and test -->
>> +       <classpathentry kind="src" path="test/resources" output="build/test" excluding="**/*.java"/>
> Is the exclude of java files readlly needed?
> Why would test/resources contain any .java files?
> And if it does, surely they are present for a reason and ought to be copied?
Java files should not be located in resources. Or do you think they 
should be allowed? What reasons would be valid?

I looked at how maven resources will be converted into eclipse paths and 
that is how they are doing it, so I reckoned it would be the right thing 
to do.

But I have no problem with removing that constraint.

Regards,
  Felix

>
>>          <classpathentry kind="lib" path="lib/api/bcmail-jdk15on-1.49.jar"/>
>>          <classpathentry kind="lib" path="lib/api/bcprov-jdk15on-1.49.jar"/>
>>          <classpathentry kind="lib" path="lib/api/bcpkix-jdk15on-1.49.jar"/>
>>
>>


Mime
View raw message