jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rainer Jung <rainer.j...@kippdata.de>
Subject Re: svn commit: r1723203 - in /jmeter/trunk: bin/jmeter.properties src/core/org/apache/jmeter/JMeter.java src/core/org/apache/jmeter/reporters/Summariser.java
Date Thu, 07 Jan 2016 04:23:46 GMT
Doesn't that change need a change log entry?

It changes user visible behavior if one uses a customized 
jmeter.properties file. I know that using a user.properties is better 
for not having to merge changes after doing an upgrade, but our docs 
frequently only mention jmeter.properties and one can use -p to load it 
from a work directory instead of the distribution provided one. Not a 
good practice but now uncommon.

So I suggest adding something like

   If you are using a custom jmeter.properties file instead of the 
default one, make sure that you include "summariser.name=summary". 
Otherwise the summariser will no longer be enabled during non-GUI testing.

About the second part, the change from 30 secs to 180 secs. I agree, 
that it is part of reverting r1550536, but all releases of the last two 
years contained that new value. So again it is a change in behavior and 
should be part of the change log. But see also the review thread on 
r1723411.

Regards,

Rainer

Am 06.01.2016 um 01:33 schrieb sebb@apache.org:
> Author: sebb
> Date: Wed Jan  6 00:33:49 2016
> New Revision: 1723203
>
> URL: http://svn.apache.org/viewvc?rev=1723203&view=rev
> Log:
>   Summariser should be enabled by default in Non GUI mode
>   Revert the changes made in r1550536 and just enable via jmeter.properties
> Bugzilla Id: 55512
>
> Modified:
>      jmeter/trunk/bin/jmeter.properties
>      jmeter/trunk/src/core/org/apache/jmeter/JMeter.java
>      jmeter/trunk/src/core/org/apache/jmeter/reporters/Summariser.java
>
> Modified: jmeter/trunk/bin/jmeter.properties
> URL: http://svn.apache.org/viewvc/jmeter/trunk/bin/jmeter.properties?rev=1723203&r1=1723202&r2=1723203&view=diff
> ==============================================================================
> --- jmeter/trunk/bin/jmeter.properties (original)
> +++ jmeter/trunk/bin/jmeter.properties Wed Jan  6 00:33:49 2016
> @@ -835,12 +835,13 @@ wmlParser.types=text/vnd.wap.wml
>   # Summariser - Generate Summary Results - configuration (mainly applies to non-GUI
mode)
>   #---------------------------------------------------------------------------
>   #
> -# Define the following property to automatically start a summariser with that name
> +# Comment the following property to disable the default non-GUI summariser
> +# [or change the value to rename it]
>   # (applies to non-GUI mode only)
> -#summariser.name=summary
> +summariser.name=summary
>   #
> -# interval between summaries (in seconds) default 30 seconds
> -#summariser.interval=30
> +# interval between summaries (in seconds) default 3 minutes
> +#summariser.interval=180
>   #
>   # Write messages to log file
>   #summariser.log=true
>
> Modified: jmeter/trunk/src/core/org/apache/jmeter/JMeter.java
> URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/JMeter.java?rev=1723203&r1=1723202&r2=1723203&view=diff
> ==============================================================================
> --- jmeter/trunk/src/core/org/apache/jmeter/JMeter.java (original)
> +++ jmeter/trunk/src/core/org/apache/jmeter/JMeter.java Wed Jan  6 00:33:49 2016
> @@ -797,7 +797,7 @@ public class JMeter implements JMeterPlu
>               convertSubTree(tree);
>
>               Summariser summer = null;
> -            String summariserName = JMeterUtils.getPropDefault("summariser.name", "summary");//$NON-NLS-1$
> +            String summariserName = JMeterUtils.getPropDefault("summariser.name", "");//$NON-NLS-1$
>               if (summariserName.length() > 0) {
>                   log.info("Creating summariser <" + summariserName + ">");
>                   println("Creating summariser <" + summariserName + ">");
>
> Modified: jmeter/trunk/src/core/org/apache/jmeter/reporters/Summariser.java
> URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/reporters/Summariser.java?rev=1723203&r1=1723202&r2=1723203&view=diff
> ==============================================================================
> --- jmeter/trunk/src/core/org/apache/jmeter/reporters/Summariser.java (original)
> +++ jmeter/trunk/src/core/org/apache/jmeter/reporters/Summariser.java Wed Jan  6 00:33:49
2016
> @@ -71,8 +71,8 @@ public class Summariser extends Abstract
>
>       private static final Logger log = LoggingManager.getLoggerForClass();
>
> -    /** interval between summaries (in seconds) default 30 seconds */
> -    private static final long INTERVAL = JMeterUtils.getPropDefault("summariser.interval",
30); //$NON-NLS-1$
> +    /** interval between summaries (in seconds) default 3 minutes */
> +    private static final long INTERVAL = JMeterUtils.getPropDefault("summariser.interval",
3 * 60); //$NON-NLS-1$
>
>       /** Write messages to log file ? */
>       private static final boolean TOLOG = JMeterUtils.getPropDefault("summariser.log",
true); //$NON-NLS-1$

Mime
View raw message