jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Philippe Mouawad <philippe.moua...@gmail.com>
Subject Re: [Bug 57319] Upgrade to HttpClient 4.5.X
Date Wed, 06 Jan 2016 12:27:27 GMT
On Wed, Jan 6, 2016 at 12:28 AM, sebb <sebbaz@gmail.com> wrote:

> On 5 January 2016 at 22:53, Philippe Mouawad
> <p.mouawad@ubik-ingenierie.com> wrote:
> > I created a bugzilla for this.
>
> However it is not mentioned on the original BZ.
>
> > It is to make release notes clear.
>
> Fixing deprecations should be part of any library version upgrades.
> Otherwise it's not a complete fix.
>
> Fixing deprecations as part of a version upgrade need not (in fact
> should not) be separately documented in changes.xml.
> Indeed it would be more confusing to show deprecation removal
> separately in this case.
>
> [However if deprecations were left over from a previous release, it
> probably would make sense to add a changes record]
>
> > If you keep it open, then do you remove it from changes.xml while we
> indeed
> > changed version and migrated cookiemanager ?
>
> Provided that the work is done before the release is cut, I see no
> reason to remove the text from changes.xml temporarily.
>

I doubt the work will be done before next release unless you want to delay
it for months:

   - As you know the upgrade was init without much progress few months ago
   - I fixed the CookieManager and as you can see it took some time and
   required 4.5.2
   - I analyzed the remaining work and I think it is rather huge, complex
   and critical as we need to:
   - Recode SlowSocketFactory equivalent
      - Recode all the HttpHC4Impl
      - Recode SSL socket factory equivalent

But of course if you think it can be fixed easily it in few days , it will
be great and I'll be happy to see it.

>
> >
> >
> > On Tuesday, January 5, 2016, <bugzilla@apache.org> wrote:
> >
> >> https://bz.apache.org/bugzilla/show_bug.cgi?id=57319
> >>
> >> Sebb <sebb@apache.org <javascript:;>> changed:
> >>
> >>            What    |Removed                     |Added
> >>
> >>
> ----------------------------------------------------------------------------
> >>          Resolution|FIXED                       |---
> >>              Status|RESOLVED                    |REOPENED
> >>
> >> --- Comment #4 from Sebb <sebb@apache.org <javascript:;>> ---
> >> There are lots of deprecation warnings still to fix.
> >>
> >> --
> >> You are receiving this mail because:
> >> You reported the bug.
> >> You are on the CC list for the bug.
> >>
> >
> >
> > --
> > Cordialement.
> > Philippe Mouawad.
> > Ubik-Ingénierie
> >
> > UBIK LOAD PACK Web Site <http://www.ubikloadpack.com/>
> >
> > UBIK LOAD PACK on TWITTER <https://twitter.com/ubikloadpack>
>



-- 
Cordialement.
Philippe Mouawad.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message