jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r1723411 - in /jmeter/trunk: bin/jmeter.properties src/core/org/apache/jmeter/reporters/Summariser.java
Date Thu, 07 Jan 2016 03:05:27 GMT
On 6 January 2016 at 21:03,  <pmouawad@apache.org> wrote:
> Author: pmouawad
> Date: Wed Jan  6 21:03:36 2016
> New Revision: 1723411
>
> URL: http://svn.apache.org/viewvc?rev=1723411&view=rev
> Log:
> [Bug 55512] Summariser should be enabled by default in Non GUI mode
> Restore 30 seconds as interval

-1

I don't agree with this for two reasons:
1) it's nothing to do with enabling the the Summariser, so would need
a different bugzilla (if agreed)
2) The interval is far too short as a default; it will cause log files
to be much longer.

> Bugzilla Id: 55512
>
> Modified:
>     jmeter/trunk/bin/jmeter.properties
>     jmeter/trunk/src/core/org/apache/jmeter/reporters/Summariser.java
>
> Modified: jmeter/trunk/bin/jmeter.properties
> URL: http://svn.apache.org/viewvc/jmeter/trunk/bin/jmeter.properties?rev=1723411&r1=1723410&r2=1723411&view=diff
> ==============================================================================
> --- jmeter/trunk/bin/jmeter.properties (original)
> +++ jmeter/trunk/bin/jmeter.properties Wed Jan  6 21:03:36 2016
> @@ -840,8 +840,8 @@ wmlParser.types=text/vnd.wap.wml
>  # (applies to non-GUI mode only)
>  summariser.name=summary
>  #
> -# interval between summaries (in seconds) default 3 minutes
> -#summariser.interval=180
> +# interval between summaries (in seconds) default 30 seconds
> +#summariser.interval=30
>  #
>  # Write messages to log file
>  #summariser.log=true
>
> Modified: jmeter/trunk/src/core/org/apache/jmeter/reporters/Summariser.java
> URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/reporters/Summariser.java?rev=1723411&r1=1723410&r2=1723411&view=diff
> ==============================================================================
> --- jmeter/trunk/src/core/org/apache/jmeter/reporters/Summariser.java (original)
> +++ jmeter/trunk/src/core/org/apache/jmeter/reporters/Summariser.java Wed Jan  6 21:03:36
2016
> @@ -71,8 +71,8 @@ public class Summariser extends Abstract
>
>      private static final Logger log = LoggingManager.getLoggerForClass();
>
> -    /** interval between summaries (in seconds) default 3 minutes */
> -    private static final long INTERVAL = JMeterUtils.getPropDefault("summariser.interval",
3 * 60); //$NON-NLS-1$
> +    /** interval between summaries (in seconds) default 30 seconds */
> +    private static final long INTERVAL = JMeterUtils.getPropDefault("summariser.interval",
30); //$NON-NLS-1$
>
>      /** Write messages to log file ? */
>      private static final boolean TOLOG = JMeterUtils.getPropDefault("summariser.log",
true); //$NON-NLS-1$
>
>

Mime
View raw message