jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Philippe Mouawad <philippe.moua...@gmail.com>
Subject Re: Fixing JMS Subscriber message count bug
Date Sun, 07 Feb 2016 20:41:24 GMT
Thanks,
I commented it :-)

On Sun, Feb 7, 2016 at 9:37 PM, Harrison Termotto <
harrison.termotto@stonybrook.edu> wrote:

> Great, PR has been created.
>
> On Sun, Feb 7, 2016 at 2:13 AM, Philippe Mouawad <
> philippe.mouawad@gmail.com
> > wrote:
>
> > Hello,
> > Thanks for proposal.
> > The process is:
> > - Open a bugzilla issue https://jmeter.apache.org/issues.html
> > - Fork mirror github.com/apache/jmeter
> > - create a branch with bugzilla id
> > - commit your fix there
> > - Create a PR and link it in the bugzilla issue
> >
> > Ensure you document any change in GUI in component_reference.xml and
> follow
> > coding guidelines
> >
> > Run following ant tasks before commiting your code
> > - ant package-and-check will check that code compile and respect tab
> policy
> > - ant test will check that full tests run fine
> >
> > Thanks
> > Regards
> >
> > On Sunday, February 7, 2016, Harrison Termotto <
> > harrison.termotto@stonybrook.edu> wrote:
> >
> > > Hi all,
> > >
> > > I'm new to this mailing list and contributing to Apache in general,
> but I
> > > believe I can fix a bug in JMeter.
> > >
> > > When using the JMS Subscriber, the subscriber will return that it was a
> > > success if it has received at least one message, regardless of how many
> > > messages the user wanted it to receive. I think this should not be
> > > considered a success, and this was actually a bug that gave me and my
> > > coworkers some trouble over the summer.
> > >
> > > I have identified where this is occurring in the code, and would like
> to
> > > know how I should go about fixing it. Is the process more involved than
> > > just forking the repo and then submitting a PR?
> > >
> > > Thanks,
> > > Harrison
> > >
> >
> >
> > --
> > Cordialement.
> > Philippe Mouawad.
> >
>



-- 
Cordialement.
Philippe Mouawad.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message