jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From FSchumacher <...@git.apache.org>
Subject [GitHub] jmeter issue #210: Added a Graphite sender to send metrics in statsd protoco...
Date Fri, 10 Jun 2016 18:28:45 GMT
Github user FSchumacher commented on the issue:

    https://github.com/apache/jmeter/pull/210
  
    Thanks for your contribution.
    
    As you can see, the checks for this PR are failing. You can find the reason by following
the link (small red cross next to the commit id) to the travis ci site (hint: you are using
tabs instead of spaces).
    
    Apart from those cosmetic things, there are a few other issues, that I noticed.
    
    There is a useless import of `GenericKeyedObjectPool` (maybe more, I haven't checked).
    I have found one `SocketOutputStream` (named `out` and initialized to `null`), that is
not used.
    `Collection#size() > 0` is used to check, whether that collection is empty. You could
use the `isEmpty()` method for that, since it can be more efficient and is more concise.
    Exceptions get logged as `String`. It would (most of the time) be nice to add them as
such to the logging instruction.
    
    Regards,
     Felix


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message