jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebbASF <...@git.apache.org>
Subject [GitHub] jmeter issue #210: Added a Graphite sender to send metrics in statsd protoco...
Date Fri, 10 Jun 2016 21:29:37 GMT
Github user sebbASF commented on the issue:

    https://github.com/apache/jmeter/pull/210
  
    Thanks.
    Also, I'm not sure why there is a separate private send method. It is only used once,
and handles only some exceptions. The caller then catches Exception which seems wrong; it
should only catch known thrown exceptions. Also the caller should probably use finally to
drop the metrics.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message