jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tpeyrard <...@git.apache.org>
Subject [GitHub] jmeter pull request #211: Measure Time to First byte in JDBCSampler
Date Wed, 29 Jun 2016 20:47:28 GMT
Github user tpeyrard commented on a diff in the pull request:

    https://github.com/apache/jmeter/pull/211#discussion_r69024424
  
    --- Diff: src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/AbstractJDBCTestElement.java
---
    @@ -147,17 +147,24 @@ protected AbstractJDBCTestElement() {
         /**
          * Execute the test element.
          * 
    -     * @param conn a {@link SampleResult} in case the test should sample; <code>null</code>
if only execution is requested
    +     * @param conn a {@link Connection}
          * @return the result of the execute command
          * @throws SQLException if a database error occurs
          * @throws UnsupportedEncodingException when the result can not be converted to the
required charset
          * @throws IOException when I/O error occurs
          * @throws UnsupportedOperationException if the user provided incorrect query type

          */
         protected byte[] execute(Connection conn) throws SQLException, IOException, UnsupportedOperationException
{
    +        return execute(conn,  new SampleResult());
    +    }
    +
    +    /**
    +     * Use the sample given as argument to set time to first byte in the "latency" field
of the SampleResult.
    +     */
    +    protected byte[] execute(Connection conn, SampleResult sample) throws SQLException,
IOException {
    --- End diff --
    
    Ok I'll have a look


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message