jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From woonsan <...@git.apache.org>
Subject [GitHub] jmeter pull request #250: Feature/bz60564 (1)
Date Thu, 12 Jan 2017 17:56:43 GMT
GitHub user woonsan opened a pull request:

    https://github.com/apache/jmeter/pull/250

    Feature/bz60564 (1)

    This is the first pull request for https://bz.apache.org/bugzilla/show_bug.cgi?id=60564.
    This PR contains only slf4j migration in ```protocol/java``` component for easier review/merging.
    
    The minor change in ```LogkitLoggerFactory.java``` in this PR is necessary for the following
reasons:
    - ```LoggingManager``` always removes the package prefix, ```org.apache.```, in the logger
category name, while ```LogkitLoggerFactory.java``` hasn't used the same category name pattern,
but used FQCN so far.
    - Because of this difference, after replacing logs with slf4j logger, the ```BatchTestLocal```
test should always fail because it keeps ```INFO``` level log lines in ```bin/BatchTestLocal.log```
even if ```bin/testfiles/jmeter-batch.properties``` contains ```log_level.jmeter=WARN```.
This is caused by the fact that slf4j logger uses FQCN logger category name and so it uses
the default INFO log level instead of the overridden WARN level in ```bin/testfiles/jmeter-batch.properties```.
    
    I also have a doubt in keeping a logger cache in ```LogkitLoggerFactory```, but that's
out of scope. The factory can be removed in the end or revisited later anyway with a new bz
ticket.
    
    Please take a review.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/woonsan/jmeter feature/bz60564-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jmeter/pull/250.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #250
    
----
commit f2abf068184bc6638c45e28093c8e58da303af19
Author: Woonsan Ko <woonsan.ko@bloomreach.com>
Date:   2017-01-12T15:52:05Z

    60564: replacing logkit logger by slf4j logger in protocol/java component.

commit 7ab226d2c6b8c25059b2761a452195dd2035ed13
Author: Woonsan Ko <woonsan.ko@bloomreach.com>
Date:   2017-01-12T17:43:12Z

    60564: fixing a minor bug in LogkitLoggerFactory.java which should have removed the package
prefix (org.apache.) like LoggingManager does.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message