jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From squarebracket <...@git.apache.org>
Subject [GitHub] jmeter issue #261: Clear querystring args on each call to setPath
Date Wed, 08 Feb 2017 00:50:18 GMT
Github user squarebracket commented on the issue:

    https://github.com/apache/jmeter/pull/261
  
    I've added a test. I verified that it failed without the fix, passes with it.
    
    I also had to change around the test [`testMakingUrl2`](https://github.com/apache/jmeter/pull/261/commits/c01f86e3e1e95865dd59bd3751f6c844c511fca8#diff-1270ca4ee51dd2a72aa5e4763424b6f9).
With my change, parameters added by calling `addArgument` before calling `setPath` are silently
lost. 
    
    I hadn't considered this when first submitting the fix. Let me know if you think it's
something that should be addressed somehow. I added a bit of documentation to the `setPath`
javadocs to reflect that those arguments are dropped, hopefully that's enough that end-users
won't get confused.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message