jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Philippe Mouawad <philippe.moua...@gmail.com>
Subject Re: svn commit: r1783635 - /jmeter/trunk/src/core/org/apache/jmeter/report/core/CsvSampleReader.java
Date Sun, 19 Feb 2017 14:30:46 GMT
Oups sorry !
Will revert.

On Sun, Feb 19, 2017 at 3:28 PM, Felix Schumacher <
felix.schumacher@internetallee.de> wrote:

>
>
> Am 19. Februar 2017 15:18:41 MEZ schrieb pmouawad@apache.org:
> >Author: pmouawad
> >Date: Sun Feb 19 14:18:41 2017
> >New Revision: 1783635
> >
> >URL: http://svn.apache.org/viewvc?rev=1783635&view=rev
> >Log:
> >Fix sonar warning
> >
> >Modified:
> >jmeter/trunk/src/core/org/apache/jmeter/report/core/CsvSampleReader.java
> >
> >Modified:
> >jmeter/trunk/src/core/org/apache/jmeter/report/core/CsvSampleReader.java
> >URL:
> >http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/
> apache/jmeter/report/core/CsvSampleReader.java?rev=
> 1783635&r1=1783634&r2=1783635&view=diff
> >===========================================================
> ===================
> >---
> >jmeter/trunk/src/core/org/apache/jmeter/report/core/CsvSampleReader.java
> >(original)
> >+++
> >jmeter/trunk/src/core/org/apache/jmeter/report/core/CsvSampleReader.java
> >Sun Feb 19 14:18:41 2017
> >@@ -112,10 +112,11 @@ public class CsvSampleReader implements
> >             isr = new InputStreamReader(fis, CHARSET);
> >             this.reader = new BufferedReader(isr, BUF_SIZE);
> >    } catch (FileNotFoundException | UnsupportedEncodingException ex) {
> >+            throw new SampleException("Could not create file reader
> >!", ex);
> >+        } finally {
> >             JOrphanUtils.closeQuietly(isr);
> >             JOrphanUtils.closeQuietly(fis);
> >             JOrphanUtils.closeQuietly(this.reader);
> >-            throw new SampleException("Could not create file reader
> >!", ex);
>
> Close the streams? Really?
>
> Felix
>
> >         }
> >         if (metadata == null) {
> >             this.metadata = readMetadata(separator, useSaveSampleCfg);
>



-- 
Cordialement.
Philippe Mouawad.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message