jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Woonsan Ko <woon...@apache.org>
Subject Re: Migration to Slf4j and backward compatibility policy
Date Fri, 10 Feb 2017 17:46:39 GMT
On Fri, Feb 10, 2017 at 1:52 AM, Philippe Mouawad
<philippe.mouawad@gmail.com> wrote:
> Hello,
> In the process of migrating, there are 2 places where we face the backward
> compatibility issue:
> - AbstractJavaSamplerClient#getLogger
> - Dynamic scripting elements (Jsr223, Bsf and Beanshell)
>
> For the first case I think we need to keep method, make it deprecated and
> propose a new one or nothing (maybe better) as it's fairly easy to create a
> logger

Thanks for spotting on! I missed that part totally.
And, I like your suggestions.
If there's no objection and if someone doesn't beat me, I'll update
the pull request with backward compatible getLogger() method later.

Cheers,

Woonsan

>
> For the second case I propose to take the risk as I think we'll only break
> scripts that use fatalError or isPriorityHigherThan (something
> similar) which do not exist in slf4j
>
> We would mention this in release notes and update component reference.
>
>
>
> Regards
> Philippe
>
>
>
>
> --
> Cordialement.
> Philippe Mouawad.

Mime
View raw message