jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Oleg Kalnichevski <ol...@apache.org>
Subject Re: MultipartEntityBuilder and Charset US-ASCII
Date Sun, 28 May 2017 10:43:20 GMT
On Sat, 2017-05-20 at 16:31 +0200, Philippe Mouawad wrote:
> Hello,
> Any thoughts on that ?
> 

Hi Philippe

This is perfectly legal. See

https://www.ietf.org/rfc/rfc1341.txt

Oleg



> Thx
> 
> On Wednesday, April 19, 2017, Philippe Mouawad <philippe.mouawad@gmai
> l.com>
> wrote:
> 
> > Hello,
> > Anybody has an idea about that ?
> > Thanks
> > 
> > On Mon, Apr 17, 2017 at 10:50 PM, Philippe Mouawad <
> > philippe.mouawad@gmail.com
> > <javascript:_e(%7B%7D,'cvml','philippe.mouawad@gmail.com');>>
> > wrote:
> > 
> > > Hello,
> > > At JMeter we have a bug report (https://bz.apache.org/bugzill
> > > a/show_bug.cgi?id=60800) related to Multipart Form POST request
> > > 
> > > A user reports that he has an issue with a request created by
> > > JMeter due
> > > to the presence in Request Headers of "charset=US-ASCII" at end
> > > of boundary
> > > in Content-Type.
> > > 
> > > ---------------------------------------------------------------
> > > ---------
> > > POST http://localhost:8081/
> > > 
> > > POST data:
> > > --5v5So93EEOXPO8DIg4kmR-vfmsbimn
> > > Content-Disposition: form-data; name="toto"
> > > 
> > > titi
> > > --5v5So93EEOXPO8DIg4kmR-vfmsbimn--
> > > 
> > > 
> > > *Request Headers:*
> > > Connection: keep-alive
> > > Content-Length: 123
> > > *Content-Type: multipart/form-data;
> > > boundary=5v5So93EEOXPO8DIg4kmR-vfmsbimn; charset=US-ASCII*
> > > Host: localhost:8081
> > > User-Agent: Apache-HttpClient/4.5.3 (Java/1.8.0_121)
> > > 
> > > ---------------------------------------------------------------
> > > ---------
> > > 
> > > The code is created through (https://github.com/apache/jme
> > > ter/blob/trunk/src/protocol/http/org/apache/jmeter/
> > > protocol/http/sampler/HTTPHC4Impl.java#L1201):
> > > 
> > > 1/            MultipartEntityBuilder multipartEntityBuilder =
> > > MultipartEntityBuilder.create();
> > > 
> > > 2/ As not Content Type is set in GUI, we default to US-ASCII so
> > > call:
> > > multipartEntityBuilder.setCharset("US-ASCII");
> > > 
> > > 3/
> > > multipartEntityBuilder.setLaxMode();
> > > 
> > > 4/ For every parameter:
> > >                 StringBody stringBody = new
> > > StringBody(arg.getValue(),
> > > ContentType.create("text/plain", charset));
> > >                 FormBodyPart formPart =
> > > FormBodyPartBuilder.create(
> > >                         parameterName, stringBody).build();
> > >                 multipartEntityBuilder.addPart(formPart);
> > > 
> > > 5/
> > >             HttpEntity entity = multipartEntityBuilder.build();
> > >             post.setEntity(entity);
> > > 
> > > 
> > > So my questions are the following:
> > > 1/ Is it correct to add this charset part ?
> > > 2/ Could you point me to the reference part of RFC that mentions
> > > this ?
> > > 3/ Is it correct to avoid setting charset in this case in API
> > > which would
> > > lead to such request instead ?
> > > 
> > > 
> > > 
> > > POST http://localhost:8081/
> > > 
> > > POST data:
> > > --xjNHd_UhEEpqC2ZoFCpGRzYzHK90ljsdpfTr
> > > Content-Disposition: form-data; name="toto"
> > > 
> > > titi
> > > --xjNHd_UhEEpqC2ZoFCpGRzYzHK90ljsdpfTr--
> > > 
> > > Request Headers:
> > > Connection: keep-alive
> > > Content-Length: 135
> > > Content-Type: multipart/form-data; boundary=xjNHd_UhEEpqC2ZoFCpGR
> > > zYzHK90ljsdpfTr
> > > Host: localhost:8081
> > > User-Agent: Apache-HttpClient/4.5.3 (Java/1.8.0_121)
> > > 
> > > 
> > > Thanks for your help
> > > Regards
> > > Philippe M.
> > > 
> > 
> > 
> > 
> > --
> > Cordialement.
> > Philippe Mouawad.
> > 
> > 
> > 
> 
> 

Mime
View raw message