jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From FSchumacher <...@git.apache.org>
Subject [GitHub] jmeter pull request #298: Vary header cache
Date Tue, 20 Jun 2017 17:34:47 GMT
Github user FSchumacher commented on a diff in the pull request:

    https://github.com/apache/jmeter/pull/298#discussion_r123043982
  
    --- Diff: src/protocol/http/org/apache/jmeter/protocol/http/control/CacheManager.java
---
    @@ -152,22 +197,18 @@ private boolean hasVaryHeader(URLConnection conn) {
          *            result to decide if result is cacheable
          */
         public void saveDetails(HttpResponse method, HTTPSampleResult res) {
    --- End diff --
    
    This is _old_ code and a result of the different implementations of the http samplers.
What refactoring do you have in mind? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message