jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From FSchumacher <...@git.apache.org>
Subject [GitHub] jmeter pull request #300: Bug 57039 - Inconsistency with the undo/redo log
Date Sun, 30 Jul 2017 08:33:31 GMT
Github user FSchumacher commented on a diff in the pull request:

    https://github.com/apache/jmeter/pull/300#discussion_r130236267
  
    --- Diff: src/core/org/apache/jmeter/gui/UndoHistoryItem.java ---
    @@ -35,31 +36,48 @@
         private final HashTree tree;
         // TODO: find a way to show this comment in menu item and toolbar tooltip
         private final String comment;
    +    private final TreeState treeState;
    +    private final boolean dirty;
     
         /**
          * This constructor is for Unit test purposes only
          * @deprecated DO NOT USE
          */
         @Deprecated
         public UndoHistoryItem() {
    -        tree = null;
    -        comment = null;
    +        this(null, null, null, false);
         }
     
         /**
          * @param copy HashTree
          * @param acomment String
          */
    -    public UndoHistoryItem(HashTree copy, String acomment) {
    +    public UndoHistoryItem(HashTree copy, String acomment, TreeState treeState, boolean
dirty) {
             tree = copy;
             comment = acomment;
    --- End diff --
    
    I would add `this.` to `copy` and `comment` to be consistent.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message