jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Maxime Chassagneux <mchassagn...@apache.org>
Subject Re: Release a 4.0 ?
Date Tue, 28 Nov 2017 22:22:25 GMT
Hi,

+1 for eclipse theme.





2017-11-28 22:21 GMT+01:00 Philippe Mouawad <philippe.mouawad@gmail.com>:

> Hello,
> Any thoughts on the proposed themes for JSyntaxTextArea ?
>
> My preference goes to my proposal (not because it's mine :-) ) as it is
> supposed to follow Darcula LAF colours except for 1 remaining difference.
>
>
> Regards
>
> On Thu, Nov 23, 2017 at 6:24 PM, Philippe Mouawad <
> philippe.mouawad@gmail.com> wrote:
>
> > Thanks Maxime for your proposal.
> > I had on my side worked on trying to port using Eclipse Darcula Theme.
> >
> > I have attached  3 proposals on https://bz.apache.org/
> > bugzilla/show_bug.cgi?id=61697:
> >
> >    - Yours
> >    - Dark theme based on Notepad++'s Obsidian theme which is similar
> >    - My proposal based on what I found  in
> http://www.eclipsecolorthemes.org/?view=theme&id=14105
> >    (there are still some differences)
> >    <http://www.eclipsecolorthemes.org/?view=theme&id=14105>
> >
> > @All, can you make a choice ?
> >
> > Thanks
> >
> > Regards
> >
> >
> >
> > On Thu, Nov 23, 2017 at 6:07 PM, Maxime Chassagneux <
> > mchassagneux@apache.org> wrote:
> >
> >> Philippe,
> >>
> >> Can you test my change color for the RSyntaxTheme ?
> >> As I said before, taste and colours are not always the same, but I find
> it
> >> more 'homogeneous'
> >>
> >> --
> >> Max
> >>
> >> 2017-11-23 15:08 GMT+01:00 Philippe Mouawad <
> >> p.mouawad@ubik-ingenierie.com>:
> >>
> >> > Hello Maxime,
> >> > Thanks for your feedback and tests.
> >> >
> >> > I have committed few minutes ago the integration of a Theme related to
> >> > Darcula.
> >> >
> >> > I am not very good at styling or colors so the theme file needs to be
> >> > adjusted a bit more.
> >> > But at least it should be less shocking.
> >> >
> >> > To adapt the style, the file is :
> >> > src/core/org/apache/jmeter/gui/util/theme/darcula_theme.xml
> >> >
> >> > Anybody willing to improve it is very welcome to commit directly if he
> >> can
> >> > or propose a PR. I'll happily merge it.
> >> >
> >> >
> >> > Regards
> >> > Philippe
> >> >
> >> >
> >> > On Thu, Nov 23, 2017 at 1:35 PM, Maxime Chassagneux <
> >> > mchassagneux@apache.org
> >> > > wrote:
> >> >
> >> > > Hi,
> >> > >
> >> > > I don't want to be the only person who block just for a question of
> >> look.
> >> > > It's just my feeling.
> >> > > I find the theme inconsistency because of the white textearea in the
> >> > middle
> >> > > of all this black but taste and colours are not always the same
> >> > >
> >> > > I also found not clear all fields are editable or not, but before
it
> >> was
> >> > > the same so...
> >> > >
> >> > > => https://www.dropbox.com/s/3b40bk2afmgxdw1/5.png?dl=0
> >> > > => https://www.dropbox.com/s/ukd9k8gljzv28cj/7.png?dl=0
> >> > >
> >> > > Btw in a screen resolution of 1280x1024, the icon menu bar doesn't
> fit
> >> > >
> >> > > => https://www.dropbox.com/s/0zr8yqwn6yg6v60/3.png?dl=0
> >> > >
> >> > > As long as people have the choice, in fact it's not really a
> problem.
> >> > >
> >> > > Regards
> >> > > Max
> >> > >
> >> > >
> >> > > 2017-11-23 12:52 GMT+01:00 Philippe Mouawad <
> >> philippe.mouawad@gmail.com
> >> > >:
> >> > >
> >> > > > Hi Andrei,
> >> > > >
> >> > > > AFAIU, this is pre-4.0 behaviour.
> >> > > > Having seen the result on many platforms I don't share your
> opinion:
> >> > > >
> >> > > >    - Windows LAF are just horrible, I had multiple times to use
> >> Windows
> >> > > for
> >> > > >    a long time, and I was just ashamed of JMeter
> >> > > >    - On Mac System LAF is nice, but still I find Darcula much
more
> >> > > >    beautiful
> >> > > >    - On Linux, I don't know
> >> > > >    - Cross Platform makes it look very 90s
> >> > > >
> >> > > > Anyway, current status is that people don't like our GUI, I am
fed
> >> up
> >> > or
> >> > > > reading tweets complaining about it and I think as Emilian Bold
> has
> >> > > > mentionned it that this is a problem, the first thing people
see
> in
> >> > > JMeter
> >> > > > is not its backend features but the GUI. And unfortunately many
> stop
> >> > > here.
> >> > > >
> >> > > > I triggered a poll on our twitter, and it seems feedback on new
> LAF
> >> is
> >> > > > rather positive:
> >> > > >
> >> > > >    - https://twitter.com/ApacheJMeter/status/925358010825957377
> >> > > >
> >> > > > 79% find it better, 12% not better and only 10% don't like it.
> >> > > >
> >> > > > Besides, regarding HIDPI, Darcula LAF seems to provide solutions
> >> even
> >> > for
> >> > > > Swing. I have not investigated it deeper but Constantin Bulenkov
> >> > intends
> >> > > to
> >> > > > backport Intellij HiDPI fixes in it.
> >> > > >
> >> > > > Still if people are nostalgic or don't like the new theme,  they
> can
> >> > > easily
> >> > > > switch.
> >> > > >
> >> > > > Regards
> >> > > >
> >> > > > Philippe
> >> > > >
> >> > > > https://twitter.com/ApacheJMeter/status/925358010825957377ht
> tps://
> >> > > > twitter.com/ApacheJMeter/status/925358010825957377
> >> > > >
> >> > > > On Thu, Nov 23, 2017 at 12:35 PM, Andrey Pokhilko <apc4@ya.ru>
> >> wrote:
> >> > > >
> >> > > > > My opinion is that default should be "System", as the safest
> >> decision
> >> > > is
> >> > > > > to use system LAF.
> >> > > > >
> >> > > > > Andrey Pokhilko
> >> > > > >
> >> > > > > 23.11.2017 14:08, Philippe Mouawad пишет:
> >> > > > > > Hi Maxime,
> >> > > > > > It didn't look that ugly to me and the overall look
was much
> >> better
> >> > > but
> >> > > > > if
> >> > > > > > it looks weird to you, it will be the same for others,
then NO
> >> GO
> >> > > until
> >> > > > > we
> >> > > > > > fix it.
> >> > > > > >
> >> > > > > > Regards
> >> > > > > >
> >> > > > > > On Thu, Nov 23, 2017 at 12:05 PM, Maxime Chassagneux
<
> >> > > > > > mchassagneux@apache.org> wrote:
> >> > > > > >
> >> > > > > >> Hi,
> >> > > > > >>
> >> > > > > >> I understand it, but for me it's a 'no go",  mostly
if this
> >> theme
> >> > is
> >> > > > the
> >> > > > > >> default one for 4.0.
> >> > > > > >> But may be I'm the only one who find it strange.
> >> > > > > >>
> >> > > > > >> Of course, if I can fix it , I will do.
> >> > > > > >>
> >> > > > > >>
> >> > > > > >> 2017-11-23 11:40 GMT+01:00 Philippe Mouawad <
> >> > > > philippe.mouawad@gmail.com
> >> > > > > >:
> >> > > > > >>
> >> > > > > >>> Hello Maxime,
> >> > > > > >>> It's because RSyntaxtTextarea is not aware
of the Darcula
> LAF.
> >> > > > > >>> If you can contribute a fix,go ahead.
> >> > > > > >>>
> >> > > > > >>> Thanks
> >> > > > > >>>
> >> > > > > >>> On Thu, Nov 23, 2017 at 11:38 AM, Maxime Chassagneux
<
> >> > > > > >>> mchassagneux@apache.org> wrote:
> >> > > > > >>>
> >> > > > > >>>> Hi,
> >> > > > > >>>>
> >> > > > > >>>> First test of Darcula theme on windows
for me, I find the
> >> > > rendering
> >> > > > of
> >> > > > > >>>> texteara ugly ( too black & white !
) .... I'm the only one
> >> with
> >> > > > this
> >> > > > > >>>> effect ? :
> >> > > > > >>>>
> >> > > > > >>>> https://www.dropbox.com/s/8h08xu0l3oj2ujt/%231.png?dl=0
> >> > > > > >>>>
> >> > > > > >>>> https://www.dropbox.com/s/grlasbkbxuscliv/%232.png?dl=0
> >> > > > > >>>>
> >> > > > > >>>>
> >> > > > > >>>>
> >> > > > > >>>>
> >> > > > > >>>>
> >> > > > > >>>>
> >> > > > > >>>>
> >> > > > > >>>> 2017-11-21 21:50 GMT+01:00 Antonio Gomes
Rodrigues <
> >> > > > ra0077@gmail.com
> >> > > > > >:
> >> > > > > >>>>
> >> > > > > >>>>> Work fine in my Linux
> >> > > > > >>>>>
> >> > > > > >>>>> Antonio
> >> > > > > >>>>>
> >> > > > > >>>>> 2017-11-21 20:28 GMT+01:00 Milamber
<milamber@apache.org
> >:
> >> > > > > >>>>>
> >> > > > > >>>>>>
> >> > > > > >>>>>> On 21/11/2017 12:36, Philippe Mouawad
wrote:
> >> > > > > >>>>>>
> >> > > > > >>>>>>> Hello,
> >> > > > > >>>>>>> Thanks Antonio for your tests,
I indeed was using laf
> name
> >> > > > instead
> >> > > > > >>> of
> >> > > > > >>>>>>> class
> >> > > > > >>>>>>> name.
> >> > > > > >>>>>>> It is working now in my tests,
but Milamber, Antonio or
> >> any
> >> > > > > >>>> subscriber,
> >> > > > > >>>>>>> your tests are welcome.
> >> > > > > >>>>>>>
> >> > > > > >>>>>> That's works for default LAF after
remove theses lines
> into
> >> > this
> >> > > > > >> file
> >> > > > > >>>>>> ~/.java/.userPrefs/org/apache/
> jmeter/gui/action/prefs.xml
> >> > > > > >>>>>>
> >> > > > > >>>>>> (removed)
> >> > > > > >>>>>> <entry key="laf" value="com.bulenkov.darcula.Da
> rculaLaf"/>
> >> > > > > >>>>>> <entry key="laf.class" value="javax.swing.plaf.metal.
> >> > > > > >>>> MetalLookAndFeel"/>
> >> > > > > >>>>>>
> >> > > > > >>>>>> Thanks
> >> > > > > >>>>>>
> >> > > > > >>>>>> Jenkins build is in progress, a
new nightly build should
> be
> >> > > > > >> available
> >> > > > > >>>> in
> >> > > > > >>>>>>> few minutes.
> >> > > > > >>>>>>> Regards
> >> > > > > >>>>>>>
> >> > > > > >>>>>>> On Tue, Nov 21, 2017 at 10:17
AM, Philippe Mouawad <
> >> > > > > >>>>>>> philippe.mouawad@gmail.com>
wrote:
> >> > > > > >>>>>>>
> >> > > > > >>>>>>> Hi Antonio,
> >> > > > > >>>>>>>> I fixed this bug on sunday.
> >> > > > > >>>>>>>> Are you using last revision
?
> >> > > > > >>>>>>>>
> >> > > > > >>>>>>>> Thanks
> >> > > > > >>>>>>>>
> >> > > > > >>>>>>>> On Tue, Nov 21, 2017 at
10:14 AM, Antonio Gomes
> >> Rodrigues <
> >> > > > > >>>>>>>> ra0077@gmail.com> wrote:
> >> > > > > >>>>>>>>
> >> > > > > >>>>>>>> Hi Philippe,
> >> > > > > >>>>>>>>> About Darcula, in Windows
10 (I will test it in Linux
> >> later
> >> > > but
> >> > > > > >> I
> >> > > > > >>>>> think
> >> > > > > >>>>>>>>> it's the same) we have
in the first launch
> >> > > > > >>>>>>>>>
> >> > > > > >>>>>>>>> 2017-11-21 10:09:26,333
INFO
> >> o.a.j.g.a.LookAndFeelCommand:
> >> > > > > >>>> Installing
> >> > > > > >>>>>>>>> Darcula LAF
> >> > > > > >>>>>>>>> 2017-11-21 10:09:26,363
INFO
> >> o.a.j.g.a.LookAndFeelCommand:
> >> > > > Using
> >> > > > > >>>> look
> >> > > > > >>>>>>>>> and
> >> > > > > >>>>>>>>> feel: Darcula []
> >> > > > > >>>>>>>>> 2017-11-21 10:09:26,363
INFO o.a.j.JMeter: Setting LAF
> >> to:
> >> > > > > >> Darcula
> >> > > > > >>>>>>>>> 2017-11-21 10:09:26,363
WARN o.a.j.JMeter: Could not
> set
> >> > LAF
> >> > > > to:
> >> > > > > >>>>> Darcula
> >> > > > > >>>>>>>>> java.lang.ClassNotFoundException:
Darcula
> >> > > > > >>>>>>>>> at java.net.URLClassLoader.findClass(Unknown
Source)
> >> > > > > >>> ~[?:1.8.0_144]
> >> > > > > >>>>>>>>> at java.lang.ClassLoader.loadClass(Unknown
Source)
> >> > > > > >> ~[?:1.8.0_144]
> >> > > > > >>>>>>>>> at java.lang.ClassLoader.loadClass(Unknown
Source)
> >> > > > > >> ~[?:1.8.0_144]
> >> > > > > >>>>>>>>> at java.lang.Class.forName0(Native
Method)
> >> ~[?:1.8.0_144]
> >> > > > > >>>>>>>>> at java.lang.Class.forName(Unknown
Source)
> >> ~[?:1.8.0_144]
> >> > > > > >>>>>>>>> at javax.swing.SwingUtilities.loadSystemClass(Unknown
> >> > > Source)
> >> > > > > >>>>>>>>> ~[?:1.8.0_144]
> >> > > > > >>>>>>>>> at javax.swing.UIManager.setLookAndFeel(Unknown
> Source)
> >> > > > > >>>>> ~[?:1.8.0_144]
> >> > > > > >>>>>>>>> at org.apache.jmeter.JMeter.startGui(JMeter.java:359)
> >> > > > > >>>>>>>>> [ApacheJMeter_core.jar:r1815865]
> >> > > > > >>>>>>>>> at org.apache.jmeter.JMeter.start(JMeter.java:520)
> >> > > > > >>>>>>>>> [ApacheJMeter_core.jar:r1815865]
> >> > > > > >>>>>>>>> at sun.reflect.NativeMethodAccess
> orImpl.invoke0(Native
> >> > > Method)
> >> > > > > >>>>>>>>> ~[?:1.8.0_144]
> >> > > > > >>>>>>>>> at sun.reflect.NativeMethodAccess
> orImpl.invoke(Unknown
> >> > > Source)
> >> > > > > >>>>>>>>> ~[?:1.8.0_144]
> >> > > > > >>>>>>>>> at sun.reflect.DelegatingMethodAc
> >> cessorImpl.invoke(Unknown
> >> > > > > >>> Source)
> >> > > > > >>>>>>>>> ~[?:1.8.0_144]
> >> > > > > >>>>>>>>> at java.lang.reflect.Method.invoke(Unknown
Source)
> >> > > > > >> ~[?:1.8.0_144]
> >> > > > > >>>>>>>>> at org.apache.jmeter.NewDriver.ma
> in(NewDriver.java:248)
> >> > > > > >>>>>>>>> [ApacheJMeter.jar:r1815865]
> >> > > > > >>>>>>>>>
> >> > > > > >>>>>>>>>
> >> > > > > >>>>>>>>> In the second launch,
all is ok
> >> > > > > >>>>>>>>>
> >> > > > > >>>>>>>>> 017-11-21 10:11:37,394
INFO
> >> o.a.j.g.a.LookAndFeelCommand:
> >> > > > > >>> Installing
> >> > > > > >>>>>>>>> Darcula LAF
> >> > > > > >>>>>>>>> 2017-11-21 10:11:37,409
INFO
> >> o.a.j.g.a.LookAndFeelCommand:
> >> > > > Using
> >> > > > > >>>> look
> >> > > > > >>>>>>>>> and
> >> > > > > >>>>>>>>> feel: com.bulenkov.darcula.DarculaLaf
[Darcula]
> >> > > > > >>>>>>>>> 2017-11-21 10:11:37,409
INFO o.a.j.JMeter: Setting LAF
> >> to:
> >> > > > > >>>>>>>>> com.bulenkov.darcula.DarculaLaf
> >> > > > > >>>>>>>>> 2017-11-21 10:11:37,455
INFO o.a.j.JMeter: Loaded icon
> >> > > > > >> properties
> >> > > > > >>>> from
> >> > > > > >>>>>>>>> org/apache/jmeter/images/icon.properties
> >> > > > > >>>>>>>>>
> >> > > > > >>>>>>>>> Antonio
> >> > > > > >>>>>>>>>
> >> > > > > >>>>>>>>>
> >> > > > > >>>>>>>>> 2017-11-21 9:52 GMT+01:00
Philippe Mouawad <
> >> > > > > >>>>> philippe.mouawad@gmail.com
> >> > > > > >>>>>>>>>> :
> >> > > > > >>>>>>>>> Hi Milamber,
> >> > > > > >>>>>>>>>> One note below
regarding LAF.
> >> > > > > >>>>>>>>>>
> >> > > > > >>>>>>>>>> Thanks
> >> > > > > >>>>>>>>>>
> >> > > > > >>>>>>>>>> On Tue, Nov 21,
2017 at 9:50 AM, Milamber <
> >> > > > milamber@apache.org
> >> > > > > >>>>> wrote:
> >> > > > > >>>>>>>>>>
> >> > > > > >>>>>>>>>>> On 20/11/2017
21:06, Philippe Mouawad wrote:
> >> > > > > >>>>>>>>>>>
> >> > > > > >>>>>>>>>>> Hello,
> >> > > > > >>>>>>>>>>>> We now
have a version that contains:
> >> > > > > >>>>>>>>>>>> - 49 enhancements
> >> > > > > >>>>>>>>>>>> - 13 bug
fixes
> >> > > > > >>>>>>>>>>>> - 6 PR
> >> > > > > >>>>>>>>>>>>
> >> > > > > >>>>>>>>>>>> Version
looks mature to me currently and brings
> >> > > interesting
> >> > > > > >> new
> >> > > > > >>>>>>>>>>> features
> >> > > > > >>>>>>>>>> and a nice new
look.
> >> > > > > >>>>>>>>>>>> +1 for
nice new look. (perhaps Dracula can be the
> >> > default
> >> > > > > >>>>> look&feel)
> >> > > > > >>>>>>>>>>> It is already.
> >> > > > > >>>>>>>>>> If it's not then
it would be an issue, I
> intentionally
> >> > > changed
> >> > > > > >>> the
> >> > > > > >>>>>>>>>> preference name
for the laf so that all users have a
> >> > chance
> >> > > to
> >> > > > > >>> see
> >> > > > > >>>>> it.
> >> > > > > >>>>>>>>>> Can you double
check and confirm please ?
> >> > > > > >>>>>>>>>>
> >> > > > > >>>>>>>>>>
> >> > > > > >>>>>>>>>>> What do you
think of releasing ?
> >> > > > > >>>>>>>>>>>> Yes before
end of the year that's will a good idea.
> >> > > > > >>>>>>>>>>>
> >> > > > > >>>>>>>>>>> There are remaining
PRs that could be merged but
> could
> >> > > > > >> introduce
> >> > > > > >>>>> more
> >> > > > > >>>>>>>>>>>> delay
> >> > > > > >>>>>>>>>>>> :
> >> > > > > >>>>>>>>>>>>
> >> > > > > >>>>>>>>>>>>      -
https://github.com/apache/jmeter/pull/320
> =>
> >> > > > > >> Migration
> >> > > > > >>> to
> >> > > > > >>>>>>>>>>>> last
> >> > > > > >>>>>>>>>>>>
> >> > > > > >>>>>>>>>>> HC4
> >> > > > > >>>>>>>>>>>      APIs but
it would need important tesint
> >> > > > > >>>>>>>>>>>>      -
https://github.com/apache/jmeter/pull/313
> =>
> >> I
> >> > > asked
> >> > > > > >> a
> >> > > > > >>>>>>>>>>> question
> >> > > > > >>>>>>>>>> about
> >> > > > > >>>>>>>>>>>>      it.
I think we should adapt it to add a
> Metadata
> >> > > > > >> property
> >> > > > > >>>>>>>>>>> instead of
> >> > > > > >>>>>>>>>> Comment
> >> > > > > >>>>>>>>>>>>
> >> > > > > >>>>>>>>>>>> Regards
> >> > > > > >>>>>>>>>>>> Philippe
M.
> >> > > > > >>>>>>>>>>>>
> >> > > > > >>>>>>>>>>>>
> >> > > > > >>>>>>>>>>>>
> >> > > > > >>>>>>>>>> --
> >> > > > > >>>>>>>>>> Cordialement.
> >> > > > > >>>>>>>>>> Philippe Mouawad.
> >> > > > > >>>>>>>>>>
> >> > > > > >>>>>>>>>>
> >> > > > > >>>>>>>> --
> >> > > > > >>>>>>>> Cordialement.
> >> > > > > >>>>>>>> Philippe Mouawad.
> >> > > > > >>>>>>>>
> >> > > > > >>>>>>>>
> >> > > > > >>>>>>>>
> >> > > > > >>>>>>>>
> >> > > > > >>>
> >> > > > > >>>
> >> > > > > >>> --
> >> > > > > >>> Cordialement.
> >> > > > > >>> Philippe Mouawad.
> >> > > > > >>>
> >> > > > > >
> >> > > > > >
> >> > > > >
> >> > > > >
> >> > > >
> >> > > >
> >> > > > --
> >> > > > Cordialement.
> >> > > > Philippe Mouawad.
> >> > > >
> >> > >
> >> >
> >> >
> >> >
> >> > --
> >> > Cordialement.
> >> > Philippe Mouawad.
> >> > Ubik-Ingénierie
> >> >
> >> > UBIK LOAD PACK Web Site <http://www.ubikloadpack.com/>
> >> >
> >> > UBIK LOAD PACK on TWITTER <https://twitter.com/ubikloadpack>
> >> >
> >>
> >
> >
> >
> > --
> > Cordialement.
> > Philippe Mouawad.
> >
> >
> >
>
>
> --
> Cordialement.
> Philippe Mouawad.
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message