jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Felix Schumacher <felix.schumac...@internetallee.de>
Subject Re: svn commit: r1816008 - in /jmeter/trunk: src/core/org/apache/jmeter/gui/ src/core/org/apache/jmeter/threads/ src/functions/org/apache/jmeter/functions/ src/protocol/http/org/apache/jmeter/protocol/http/control/ src/protocol/jms/org/apache/jmeter/protoc...
Date Sat, 25 Nov 2017 10:58:38 GMT
Am 23.11.2017 um 12:30 schrieb Felix Schumacher:
> Am 23.11.2017 12:04, schrieb Milamber:
>> neon.3
>
> Strange. If I read 
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=206345 correctly, this 
> was a bug in eclipse, but should be fixed with newer releases.
>
> I have testet with neon.1 (I believe it was 1a)

Actually I had checked with oxygen 1.a, which is newer than neon and 
doesn't show this behaviour. So I think that warning was a false 
positive from an old eclipse version and will revert the changes.

Felix
>
> I still think, that multiline @code tags are valid and this is a false 
> positive from eclipse.
> I haven't found an official statement on multiline inline tags in 
> javadoc, though.
>
> Felix
>
>>
>> Le 23 nov. 2017 11:04, "Milamber" <milamberspace@gmail.com> a écrit :
>>
>>> neon.3
>>>
>>> Le 23 nov. 2017 11:02, "Felix Schumacher" <felix.schumacher@
>>> internetallee.de> a écrit :
>>>
>>>>
>>>>
>>>> Am 23. November 2017 07:59:39 MEZ schrieb Milamber 
>>>> <milamber@apache.org>:
>>>> >
>>>> >
>>>> >On 22/11/2017 20:00, Felix Schumacher wrote:
>>>> >> Am 22.11.2017 um 19:13 schrieb Milamber:
>>>> >>>
>>>> >>>
>>>> >>> On 22/11/2017 16:17, Felix Schumacher wrote:
>>>> >>>>
>>>> >>>> Am 22. November 2017 10:43:09 MEZ schrieb Milamber
>>>> >>>> <milamber@apache.org>:
>>>> >>>>>
>>>> >>>>> On 22/11/2017 08:18, Felix Schumacher wrote:
>>>> >>>>>> Am 22. November 2017 08:53:54 MEZ schrieb milamber@apache.org:
>>>> >>>>>>> Author: milamber
>>>> >>>>>>> Date: Wed Nov 22 07:53:54 2017
>>>> >>>>>>> New Revision: 1816008
>>>> >>>>>>>
>>>> >>>>>>> URL: http://svn.apache.org/viewvc?rev=1816008&view=rev
>>>> >>>>>>> Log:
>>>> >>>>>>> Fix some javadoc issues
>>>> >>>>>>>
>>>> >>>>>>> Modified:
>>>> >>>>>>> jmeter/trunk/src/core/org/apache/jmeter/gui/GuiPackage.java
>>>> >>>>> Modified:
>>>> >>>>>>>
>>>> >jmeter/trunk/src/functions/org/apache/jmeter/functions/CSVRead.java
>>>> >>>>>>> URL:
>>>> >>>>>>>
>>>> >>>>>
>>>> >http://svn.apache.org/viewvc/jmeter/trunk/src/functions/org
>>>> /apache/jmeter/functions/CSVRead.java?rev=1816008&r1=1816007
>>>> &r2=1816008&view=diff
>>>> >
>>>> >>>>>
>>>> >>>>>
>>>> >===========================================================
>>>> ===================
>>>> >
>>>> >>>>>
>>>> >>>>>>> ---
>>>> >>>>>
>>>> >jmeter/trunk/src/functions/org/apache/jmeter/functions/CSVRead.java
>>>> >>>>>>> (original)
>>>> >>>>>>> +++
>>>> >>>>>
>>>> >jmeter/trunk/src/functions/org/apache/jmeter/functions/CSVRead.java
>>>> >>>>>>> Wed Nov 22 07:53:54 2017
>>>> >>>>>>> @@ -35,11 +35,11 @@ import org.slf4j.LoggerFactory;
>>>> >>>>>>> * line-thru the data in the CSV file - one line
per each test.
>>>> >E.g.
>>>> >>>>>>> inserting
>>>> >>>>>>>    * the following in the test scripts :
>>>> >>>>>>>    *
>>>> >>>>>>> - * <pre>{@code
>>>> >>>>>>> + * <pre>{@code}
>>>> >>>>>> Are you sure the closing bracket is correct here?
>>>> >>>>> It's was a warning from eclipse...
>>>> >>>> Which version of Java did your workspace use?
>>>> >>>
>>>> >>> Java 8
>>>> >>
>>>> >> Strange. I didn't get any warnings. But now - with the current 
>>>> code -
>>>> >
>>>> >> I get a warning about {@code}: "Description expected after @code"
>>>> >>
>>>> >> What warning did you get?
>>>> >
>>>> > From Eclipse check: Javadoc: Missing closing brace for inline tag
>>>>
>>>> Which version of eclipse do you use?
>>>>
>>>> >
>>>> >
>>>> >>
>>>> >> Felix
>>>> >>>
>>>> >>>
>>>> >>>>
>>>> >>>> Felix
>>>> >>>>
>>>> >>>>>
>>>> >>>>>>> * ${__CSVRead(c:/BOF/abcd.csv,0)} // read (first)
line of
>>>> >>>>>>> 'c:/BOF/abcd.csv' ,
>>>> >>>>>>> - * return the 1<sup>st</sup> column
( represented by the 
>>>> '0'),
>>>> >>>>>>> + * return the 1st column (represented by the
'0'),
>>>> >>>>>> Is the sup doing any harm?
>>>> >>>>>>
>>>> >>>>>>> * ${__CSVRead(c:/BOF/abcd.csv,1)} // read (first)
line of
>>>> >>>>>>> 'c:/BOF/abcd.csv' ,
>>>> >>>>>>> - * return the 2<sup>nd</sup> column
( represented by the 
>>>> '1'),
>>>> >>>>>>> + * return the 2nd column (represented by the
'1'),
>>>> >>>>>>> * ${__CSVRead(c:/BOF/abcd.csv,next())} // Go
to next line of
>>>> >>>>>>> 'c:/BOF/abcd.csv'
>>>> >>>>>>>    * }</pre>
>>>> >>>>>>> * NOTE: A single instance of each different
file is opened and
>>>> >used
>>>> >>>>> for
>>>> >>>>>>> all
>>>> >>>>>>>



Mime
View raw message