jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From FSchumacher <...@git.apache.org>
Subject [GitHub] jmeter pull request #342: More edge cases for changeCase function and slight...
Date Sat, 25 Nov 2017 13:59:00 GMT
GitHub user FSchumacher opened a pull request:

    https://github.com/apache/jmeter/pull/342

    More edge cases for changeCase function and slight behaviour changes.

    ## Description
    Addition of more examples to test with the different change case modes.
    We now really split on all non alpha numeric characters - even unicode ones.
    The input strings for the camel case modes get trimmed before further actions.
    
    A further question is, whether we should trim the input in the other modes as well?
    For example "` space in front`" + `capitalize` = "`Space in front`" or "` space in front`"?
    
    
    ## Motivation and Context
    The handling of whitespace and other non alphanumeric characters was not well defined.
    
    ## How Has This Been Tested?
    unit tests are added and run
    
    ## Screenshots (if appropriate):
    
    ## Types of changes
    - Bug fix (non-breaking change which fixes an issue)
    
    ## Checklist:
    <!--- Go over all the following points, and put an `x` in all the boxes that apply.
-->
    <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help!
-->
    - [x] My code follows the [code style][style-guide] of this project.
    - [x] I have updated the documentation accordingly.
    
    [style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/FSchumacher/jmeter camel-case-examples

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jmeter/pull/342.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #342
    
----
commit 3d576bfca9eb2503f7ba04c083f7e3d9167751b9
Author: Felix Schumacher <felix.schumacher@internetallee.de>
Date:   2017-11-25T13:47:53Z

    More edge cases for changeCase function and slight behaviour changes.
    
    Addition of more examples to test with the different change case modes.
    We now really split on all non alpha numeric characters - even unicode ones.
    The input strings for the camel case modes get trimmed before further actions.

----


---

Mime
View raw message